Bug 194553 - [WPE][GTK][STABLE] Remove sandbox APIs from 2.24 branch
Summary: [WPE][GTK][STABLE] Remove sandbox APIs from 2.24 branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-12 12:54 PST by Michael Catanzaro
Modified: 2019-02-14 03:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.62 KB, patch)
2019-02-12 12:55 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Patch (57.99 KB, patch)
2019-02-13 10:47 PST, Michael Catanzaro 		cgarcia: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-02-12 12:54:06 PST 
Remove the sandbox APIs from the 2.24 branch, since they haven't received enough testing yet.

My patch in bug #194274 upgrades the Since tags to 2.26, for trunk.
Comment 1 Michael Catanzaro 2019-02-12 12:55:01 PST 
Created attachment 361824 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-02-12 23:32:15 PST 
Comment on attachment 361824 [details]
Patch

Not only the APIs, we should remove the implementation as well, we don't want dead code in the stable branch
Comment 3 Michael Catanzaro 2019-02-13 08:37:46 PST 
I think all the code is guarded by ENABLE(BUBBLEWRAP_SANDBOX), so it should not be built. I can remove it all if you want, but there's probably no benefit, and there's a small cost in making backports harder.
Comment 4 Carlos Garcia Campos 2019-02-13 09:01:57 PST 
(In reply to Michael Catanzaro from comment #3)
> I think all the code is guarded by ENABLE(BUBBLEWRAP_SANDBOX), so it should
> not be built. I can remove it all if you want, but there's probably no
> benefit, and there's a small cost in making backports harder.

We are not going to backport any sandbox fix anyway.
Comment 5 Michael Catanzaro 2019-02-13 10:47:25 PST 
Created attachment 361925 [details]
Patch
Comment 6 Carlos Garcia Campos 2019-02-14 03:31:28 PST 
Committed r241540: <https://trac.webkit.org/changeset/241540>