Bug 194368 - REGRESSION (r240727) [ Mac iOS ] Layout Test http/tests/workers/service/basic-register-exceptions.html is flaky
Summary: REGRESSION (r240727) [ Mac iOS ] Layout Test http/tests/workers/service/basic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 17:31 PST by Shawn Roberts
Modified: 2019-04-23 08:37 PDT (History)
9 users (show)

See Also:


Attachments
Updating TestExpectations (2.34 KB, patch)
2019-02-20 09:35 PST, Shawn Roberts
no flags Details | Formatted Diff | Diff
Patch (8.95 KB, patch)
2019-04-22 13:55 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Roberts 2019-02-06 17:31:30 PST
The following layout test is flaky on Mac and iOS

http/tests/workers/service/basic-register-exceptions.html

Probable cause:

Test became a regression after 240727

Reproduced with:

run-webkit-tests d240727 http/tests/workers/service/basic-register-exceptions.html --iterations 5000 -f --exit-after-n-failures=1 --no-retry-failures --debug

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-register-exceptions.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-register-exceptions-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-register-exceptions-actual.txt
@@ -5,5 +5,6 @@
 CONSOLE MESSAGE: line 60: Registration failed with error: TypeError: Scope URL provided to serviceWorker.register() must be either HTTP or HTTPS
 CONSOLE MESSAGE: line 70: Registration failed with error: TypeError: Scope URL provided to serviceWorker.register() cannot have a path that contains '%2f' or '%5c'
 CONSOLE MESSAGE: line 80: Registration failed with error: SecurityError: Script origin does not match the registering client's origin
+CONSOLE MESSAGE: line 10: Registration failed with error: TypeError: Script load failed
 CONSOLE MESSAGE: line 91: Registration failed with error: SecurityError: Scope origin does not match the registering client's origin
Comment 1 Radar WebKit Bug Importer 2019-02-08 18:47:35 PST
<rdar://problem/47937467>
Comment 2 Shawn Roberts 2019-02-20 09:35:05 PST
Created attachment 362505 [details]
Updating TestExpectations
Comment 3 WebKit Commit Bot 2019-02-20 10:15:06 PST
Comment on attachment 362505 [details]
Updating TestExpectations

Clearing flags on attachment: 362505

Committed r241819: <https://trac.webkit.org/changeset/241819>
Comment 4 WebKit Commit Bot 2019-02-20 10:15:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Shawn Roberts 2019-02-20 10:31:07 PST
Reopened until fix is landed.
Comment 6 Shawn Roberts 2019-03-11 13:40:02 PDT
Additional repro information. 

Test appears to only fail locally when I run it in full parallel, or when running with other tests. 

Example :

Had one window run-webkit-tests --child-processes 4 --debug --force

Another window run-webkit-tests http/tests/workers/service/basic-register-exceptions.html --iterations 1000 --child-processes 1 --force --debug

The test would fail.

When I run the test by itself with only 1 child process I am unable to reproduce it locally.
Comment 7 youenn fablet 2019-04-22 13:48:26 PDT
I do not think this is a regression, it is just that the test is flaky by nature.
I'll fix it.
Comment 8 youenn fablet 2019-04-22 13:55:04 PDT
Created attachment 367969 [details]
Patch
Comment 9 WebKit Commit Bot 2019-04-23 08:37:03 PDT
Comment on attachment 367969 [details]
Patch

Clearing flags on attachment: 367969

Committed r244539: <https://trac.webkit.org/changeset/244539>
Comment 10 WebKit Commit Bot 2019-04-23 08:37:05 PDT
All reviewed patches have been landed.  Closing bug.