Bug 193747 – Refactor ServiceWorkerJob management by ServiceWorkerContainer to make it more memory safe

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

This should fix some memory ref cycles and would also ensure that network process does not wait until the end of day for the job to be finished.

[youenn fablet]

<rdar://problem/47498196>

[youenn fablet]

Created attachment 359971 [details]
Patch

[Alex Christensen]

Comment on attachment 359971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359971&action=review

> Source/WebCore/ChangeLog:11
> +        Covered by existing tests.

Why were there no changes to existing tests then?

[David Kilzer (:ddkilzer)]

Comment on attachment 359971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359971&action=review

r=me

>> Source/WebCore/ChangeLog:11
>> +        Covered by existing tests.
> 
> Why were there no changes to existing tests then?

To reproduce the leak, you must run WK2 tests with --leaks flag and have it check the com.apple.WebKit.WebContent.Development process for leaks.  (In other words, this would be caught by a leaks bot if we had a WK2 leaks bot.)

There is an uncommitted patch to do that, but I haven't had time to clean it up for review.  See Bug 193772.

[youenn fablet]

(In reply to youenn fablet from comment #0)
> This should fix some memory ref cycles and would also ensure that network
> process does not wait until the end of day for the job to be finished.

Hum, patch does not fix a pre-existing setPendingActivity/unsetPendingActivity issue...
Let's do a more complete patch.

[youenn fablet]

Created attachment 360146 [details]
Patch

[youenn fablet]

Created attachment 360180 [details]
Patch

[youenn fablet]

Created attachment 360360 [details]
Patch

[youenn fablet]

Ping review

[Chris Dumez]

Comment on attachment 360360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360360&action=review

r=me with comments

> Source/WebCore/ChangeLog:14
> +        Before the patch, the jobs map was never cleared, which is creating a ref cycle whenever a job is not succesfull.

typo: succesfull

> Source/WebCore/ChangeLog:16
> +        Before the patch, unsetPendingActivity was only called for successful jobs finishing.

"successful", there it is.

> Source/WebCore/workers/service/ServiceWorkerContainer.h:125
> +        RefPtr<PendingActivity<ServiceWorkerContainer>> pendingActivity;

Can this be a Ref<> ?

> Source/WebCore/workers/service/ServiceWorkerJob.h:50
> +class ServiceWorkerJob : public WorkerScriptLoaderClient {

WTF_MAKE_FAST_ALLOCATED; since you're dropping RefCounted.

[youenn fablet]

> > Source/WebCore/workers/service/ServiceWorkerContainer.h:125
> > +        RefPtr<PendingActivity<ServiceWorkerContainer>> pendingActivity;
> 
> Can this be a Ref<> ?

This would need to add type traits for empty value.
This seemed like overkill to me since we are never accessing the pendingActivity.
I guess we could make it private or make OngoingJob a class if we want to.

> > Source/WebCore/workers/service/ServiceWorkerJob.h:50
> > +class ServiceWorkerJob : public WorkerScriptLoaderClient {
> 
> WTF_MAKE_FAST_ALLOCATED; since you're dropping RefCounted.

OK

[youenn fablet]

Created attachment 360602 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 360602 [details]
Patch for landing

Clearing flags on attachment: 360602

Committed r240727: <https://trac.webkit.org/changeset/240727>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.