Bug 194241 – Make WebEvent::Modifiers an OptionSet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Convert the uses of WebEvent::Modifiers as a bitmap to an OptionSet. The benefit of this is improved type safety and LLDB pretty-printing.

[Daniel Bates]

Created attachment 361101 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Daniel Bates]

Created attachment 361106 [details]
To land

[Daniel Bates]

Transcript from #webkit today (02/04/2019):

[3:14pm] dydz: I got a scary GTK API warning message in <https://bugs.webkit.org/show_bug.cgi?id=194241#c2>
[3:14pm] aperezdc: dydz: I have a few minutes before going to sleep
[3:14pm] dydz: aperezdc: ^^^
[3:14pm] dydz: Is this change kosher?
[3:14pm] dydz: I changed the private API
[3:16pm] dydz: aperezdc: I changed the signature of webkitWebViewMouseTargetChanged
[3:17pm] aperezdc: It looks good on a cursory glance, give me a moment to go over it at a slower pace
[3:17pm] dydz: aperezdc: Please do!
[3:25pm] dydz: aperezdc: You have me waiting with bated breath
[3:36pm] annulen: WebKitWebViewPrivate.h and WebViewPrivate.h don't look like a part of public api, they should probably be excluded from watchlist which triggers warning
[3:36pm] aperezdc: dydz: yup, I would r+ if I was a reviewer

[EWS Watchlist]

Comment on attachment 361106 [details]
To land

Attachment 361106 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11032987

New failing tests:
pageoverlay/overlay-large-document.html
pageoverlay/overlay-installation.html
pageoverlay/overlay-large-document-scrolled.html

[EWS Watchlist]

Created attachment 361147 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Daniel Bates]

Created attachment 361241 [details]
To land

Updated patch to make WebEvent::Modifier an enum class and give it a width of uint8_t. This makes it more closely match the enum class of the same name in WebCore::PlatformEvent.

[Daniel Bates]

Comment on attachment 361241 [details]
To land

Clearing flags on attachment: 361241

Committed r241000: <https://trac.webkit.org/changeset/241000>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47836218>

[Daniel Bates]

Committed build fix in <https://trac.webkit.org/changeset/241001>.

[Daniel Bates]

Committed more build fixes in <https://trac.webkit.org/changeset/241006> and <https://trac.webkit.org/changeset/241007>.