Bug 191446 – [iOS] Mouse/Touch/Pointer events are missing modifier keys

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Seen on an iPad running iOS 12 with a hardware keyboard attached.

All modifier keys are false in a non-programmatically-generated mouse event regardless of whether a modifier key was held when the mouse event was created. I noticed this when using the Contact app on iCloud.com. You can observe this issue yourself by performing the following:

1. Visit <https://icloud.com> and sign in.
2. Tap Contacts.
3. Tap on some contact.
4. Hold down the Shift key on the keyboard and tap another contact.

Then all contacts between the first contact tapped in (3) and the last contact tapped in (4) should be selected. But only the last tapped contact in (4) is selected.

[Radar WebKit Bug Importer]

<rdar://problem/45929460>

[Daniel Bates]

(In reply to Daniel Bates from comment #0)
> Seen on an iPad running iOS 12 with a hardware keyboard attached.
> 
> All modifier keys are false in a non-programmatically-generated mouse event
> regardless of whether a modifier key was held when the mouse event was
> created. I noticed this when using the Contact app on iCloud.com. You can
> observe this issue yourself by performing the following:
> 
> 1. Visit <https://icloud.com> and sign in.
> 2. Tap Contacts.
> 3. Tap on some contact.
> 4. Hold down the Shift key on the keyboard and tap another contact.
> 
> Then all contacts between the first contact tapped in (3) and the last
> contact tapped in (4) should be selected. But only the last tapped contact
> in (4) is selected.

iCloud seems to use touch events on iOS and does not check for modifier flags. iCloud will address this in <rdar://problem/47856410>. Re-purposing this bug to wire up modifier keys for mouse, touch/pointer events.

[Daniel Bates]

Created attachment 361342 [details]
Work-in-progress patch

[EWS Watchlist]

Attachment 361342 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:139:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 361421 [details]
Now with an untested test!

Now packed with a build fix and fortified with an untested test!

[EWS Watchlist]

Attachment 361421 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:139:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 361427 [details]
Work-in-progress patch

[EWS Watchlist]

Attachment 361427 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:125:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 361435 [details]
Work-in-progress patch

[EWS Watchlist]

Attachment 361435 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 361435 [details]
Work-in-progress patch

Attachment 361435 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11071010

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html

[EWS Watchlist]

Created attachment 361447 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361435 [details]
Work-in-progress patch

Attachment 361435 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11070987

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html

[EWS Watchlist]

Created attachment 361455 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361435 [details]
Work-in-progress patch

Attachment 361435 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11071113

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 361456 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361435 [details]
Work-in-progress patch

Attachment 361435 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11071550

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html
http/tests/security/anchor-download-block-crossorigin.html

[EWS Watchlist]

Created attachment 361458 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Daniel Bates]

Created attachment 361538 [details]
Patch and layout tests

[EWS Watchlist]

Attachment 361538 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 361538 [details]
Patch and layout tests

Attachment 361538 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11083528

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html

[EWS Watchlist]

Created attachment 361551 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361538 [details]
Patch and layout tests

Attachment 361538 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11083509

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html
http/tests/security/anchor-download-block-crossorigin.html

[EWS Watchlist]

Created attachment 361553 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361538 [details]
Patch and layout tests

Attachment 361538 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11083625

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 361556 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361538 [details]
Patch and layout tests

Attachment 361538 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11085491

New failing tests:
http/tests/adClickAttribution/anchor-tag-attributes-validation.html

[EWS Watchlist]

Created attachment 361575 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Daniel Bates]

Created attachment 361637 [details]
Patch and layout tests

[EWS Watchlist]

Attachment 361637 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Created attachment 361639 [details]
Patch and layout tests

[EWS Watchlist]

Attachment 361639 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 361639 [details]
Patch and layout tests

Attachment 361639 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11101945

New failing tests:
http/tests/security/anchor-download-block-crossorigin.html

[EWS Watchlist]

Created attachment 361641 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361639 [details]
Patch and layout tests

Attachment 361639 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11102004

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 361642 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Daniel Bates]

Created attachment 361646 [details]
Patch and layout tests

Also patch up _hoverGestureRecognizerChanged

[EWS Watchlist]

Attachment 361646 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 361646 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=361646&action=review

> LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:-2
> -CONSOLE MESSAGE: line 107: adcampaignid must have a non-negative value less than 64 for Ad Click Attribution.

We should really fix these

[Daniel Bates]

Created attachment 361696 [details]
Cat for Tim

[Daniel Bates]

Comment on attachment 361646 [details]
Patch and layout tests

Clearing flags on attachment: 361646

Committed r241272: <https://trac.webkit.org/changeset/241272>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

Build fix in http://trac.webkit.org/r241276

[WebKit Commit Bot]

Re-opened since this is blocked by bug 194513

[Daniel Bates]

Committed r241282: <https://trac.webkit.org/changeset/241282>