Bug 193890 - [ews-app] Add method to save Step data to database
Summary: [ews-app] Add method to save Step data to database
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-27 19:44 PST by Aakash Jain
Modified: 2019-01-29 13:02 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (4.19 KB, patch)
2019-01-28 04:47 PST, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-01-27 19:44:38 PST
We should add method to save Step data to database for ews-app.
Comment 1 Aakash Jain 2019-01-28 04:47:45 PST
Created attachment 360333 [details]
Proposed patch

Tested on a local instance.
Comment 2 Aakash Jain 2019-01-28 11:28:35 PST
This patch should apply to ToT after https://bugs.webkit.org/show_bug.cgi?id=193883
Comment 3 Lucas Forschler 2019-01-28 11:31:38 PST
Comment on attachment 360333 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360333&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/step.py:55
> +            # If the stepd data is already present in database, update it, e.g.: step complete event.

possible typo: stepd?
Comment 4 Aakash Jain 2019-01-29 13:01:29 PST
Committed r240605: <https://trac.webkit.org/changeset/240605>
Comment 5 Radar WebKit Bug Importer 2019-01-29 13:02:38 PST
<rdar://problem/47642762>