Bug 193735 – [ews-app] Add method to save Build data to database

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We should add method to save Build data to database for ews-app.

[Aakash Jain]

Created attachment 359931 [details]
Proposed path

[Lucas Forschler]

Comment on attachment 359931 [details]
Proposed path

View in context: https://bugs.webkit.org/attachment.cgi?id=359931&action=review

logic looks good to me, with possible name/refactoring.

> Tools/BuildSlaveSupport/ews-app/ews/common/util.py:46
> +def is_valid_int_id(id):

would this be ok as 'is_valid_id' ?

> Tools/BuildSlaveSupport/ews-app/ews/models/build.py:51
> +    def save_build(cls, patch_id, buildid, builderid, number, result, state_string, started_at, complete_at=None):

since we are using underscores for patch_id, should we continue that with build_id, builder_id?

> Tools/BuildSlaveSupport/ews-app/ews/models/build.py:72
> +        if not (util.is_valid_int_id(patch_id) and util.is_valid_int_id(buildid) and util.is_valid_int_id(builderid)  and util.is_valid_int_id(number)):

nit: extra space before the last 'and'

[Aakash Jain]

Created attachment 360334 [details]
Updated patch

> would this be ok as 'is_valid_id' ?
renamed. Also updated the method to make it more generic.

> since we are using underscores for patch_id, should we continue that with build_id, builder_id?
Uploaded Patch for this change in https://bugs.webkit.org/show_bug.cgi?id=193883 Also updated this patch to use build_id, builder_id.

> nit: extra space before the last 'and'
Fixed.

Also added some more functionality (e.g.: update_build() method). Can you please review again?

[Aakash Jain]

This patch should apply to ToT after https://bugs.webkit.org/show_bug.cgi?id=193883

[WebKit Commit Bot]

Comment on attachment 360334 [details]
Updated patch

Rejecting attachment 360334 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 360334, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/10926382

[Aakash Jain]

Committed r240603: <https://trac.webkit.org/changeset/240603>

[Radar WebKit Bug Importer]

<rdar://problem/47612792>