RESOLVED FIXED 193676
check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters 
https://bugs.webkit.org/show_bug.cgi?id=193676
Summary check-webkit-style reports false-positive whitespace/init warning in C++ init...
David Kilzer (:ddkilzer)
Reported 2019-01-22 11:16:22 PST
check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters. Happens with Bug 193654 Attachment 359696 [details] patch on these lines: PreviewConverter::PreviewConverter(id delegate, const ResourceResponse& response, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } PreviewConverter::PreviewConverter(NSData *data, const String& uti, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } Basically, the whitespace/init method needs to ignore the colon at the beginning of the line inside the first C++ initialization parameter.
Attachments
Patch v1 (6.28 KB, patch)
2019-01-22 11:57 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2019-01-22 11:57:34 PST
Created attachment 359759 [details] Patch v1
WebKit Commit Bot
Comment 2 2019-01-22 14:51:24 PST
Comment on attachment 359759 [details] Patch v1 Clearing flags on attachment: 359759 Committed r240299: <https://trac.webkit.org/changeset/240299>
WebKit Commit Bot
Comment 3 2019-01-22 14:51:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-01-22 14:52:28 PST
<rdar://problem/47461487>
Note You need to log in before you can comment on or make changes to this bug.