check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters. Happens with Bug 193654 Attachment 359696 [details] patch on these lines: PreviewConverter::PreviewConverter(id delegate, const ResourceResponse& response, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } PreviewConverter::PreviewConverter(NSData *data, const String& uti, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } Basically, the whitespace/init method needs to ignore the colon at the beginning of the line inside the first C++ initialization parameter.
Created attachment 359759 [details] Patch v1
Comment on attachment 359759 [details] Patch v1 Clearing flags on attachment: 359759 Committed r240299: <https://trac.webkit.org/changeset/240299>
All reviewed patches have been landed. Closing bug.
<rdar://problem/47461487>