Bug 193654 - Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
Summary: Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-21 08:49 PST by David Kilzer (:ddkilzer)
Modified: 2019-01-22 12:12 PST (History)
9 users (show)

See Also:


Attachments
Patch v1 (35.41 KB, patch)
2019-01-21 08:59 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v1 showing file moves via git (31.63 KB, patch)
2019-01-21 09:00 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (31.63 KB, patch)
2019-01-21 10:07 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-01-21 08:49:57 PST
Switch remaining QuickLook soft-linking in WebCore over to QuickLookSoftLink.{cpp,h}.

Also move QuickLookSoftLink.{cpp,h} into the PAL project where QuickLookSPI.h resides.

This gets rid of 3 instances of duplicate soft-linking code for QuickLook.framework.

Note that the patch on Bug 193645 updates check-webkit-style to remind patch authors about other frameworks that have *SoftLink.{cpp,h,mm} files, including QuickLook.
Comment 1 Radar WebKit Bug Importer 2019-01-21 08:50:59 PST
<rdar://problem/47430290>
Comment 2 David Kilzer (:ddkilzer) 2019-01-21 08:59:47 PST
Created attachment 359693 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2019-01-21 09:00:53 PST
Created attachment 359694 [details]
Patch v1 showing file moves via git

More concise patch showing file moves and changes within the moved files.
Comment 4 EWS Watchlist 2019-01-21 09:02:17 PST
Attachment 359694 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:47:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:52:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 David Kilzer (:ddkilzer) 2019-01-21 10:07:44 PST
Created attachment 359696 [details]
Patch v2

Rebase patch and update title.
Comment 6 EWS Watchlist 2019-01-21 10:10:09 PST
Attachment 359696 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:47:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:52:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 David Kilzer (:ddkilzer) 2019-01-22 11:17:05 PST
(In reply to Build Bot from comment #6)
> Attachment 359696 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:47:  Missing
> spaces around :  [whitespace/init] [4]
> ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:52:  Missing
> spaces around :  [whitespace/init] [4]
> Total errors found: 2 in 11 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Filed Bug 193676 to track these false positive warnings:

Bug 193676: check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
Comment 8 WebKit Commit Bot 2019-01-22 12:12:43 PST
Comment on attachment 359696 [details]
Patch v2

Clearing flags on attachment: 359696

Committed r240272: <https://trac.webkit.org/changeset/240272>
Comment 9 WebKit Commit Bot 2019-01-22 12:12:45 PST
All reviewed patches have been landed.  Closing bug.