Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. This quirk is for ceac.state.gov specifically.
<rdar://problem/34368591>
Created attachment 359238 [details] Patch
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:661 > + The new line should be deleted.
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:662 > +bool HTMLFormControlElement::needsSiteSpecificQuirks() const The name should say what the quirk is about. What if we had more than one quirk?
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/ChangeLog:9 > + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? >>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >> >> The name should say what the quirk is about. What if we had more than one quirk? > > The name should say what the quirk is about. What if we had more than one quirk? E.g. needsMouseFocusableQuirk()
Comment on attachment 359238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review Thanks Chris for reviewing the patch. >> Source/WebCore/ChangeLog:9 >> + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. > > Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? Sure, improved. >>>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >>> >>> The name should say what the quirk is about. What if we had more than one quirk? >> >> The name should say what the quirk is about. What if we had more than one quirk? > > E.g. needsMouseFocusableQuirk() Hopefully not. Fixed.
Created attachment 359287 [details] Patch
Comment on attachment 359287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359287&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:660 > Added: // FIXME: We should remove the quirk once <rdar://problem/47334655> is fixed.
Comment on attachment 359287 [details] Patch Thanks!
Created attachment 359392 [details] Patch for landing
(In reply to Brent Fulgham from comment #10) > Comment on attachment 359287 [details] > Patch > > Thanks! Thanks for r+ it.
Comment on attachment 359392 [details] Patch for landing Clearing flags on attachment: 359392 Committed r240122: <https://trac.webkit.org/changeset/240122>
*** Bug 267449 has been marked as a duplicate of this bug. ***