Bug 193333 – WebDriver: update Create Browsing Context implementation to support newest specification

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Blaze Burg]

.

[Blaze Burg]

<rdar://problem/45649489>

[Blaze Burg]

Created attachment 358833 [details]
Patch

[Blaze Burg]

Patch depends on https://bugs.webkit.org/show_bug.cgi?id=193331. I will tickle EWS once that lands via cq.

[Blaze Burg]

Created attachment 358837 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 358837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review

This looks good to me. An apple reviewer might want to check the new API, though.

> Source/WebKit/UIProcess/Automation/Automation.json:335
>                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}

Should we change this now too? Using the enum too and renamed as presentationHint.

[Blaze Burg]

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.
> 
> > Source/WebKit/UIProcess/Automation/Automation.json:335
> >                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}
> 
> Should we change this now too? Using the enum too and renamed as
> presentationHint.

Sure, we can do that.

[Blaze Burg]

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.

Since I posted the patch, Wenson took a look and was okay with the changes.

[Blaze Burg]

Created attachment 358920 [details]
For Landing

[Blaze Burg]

Committed r239988: <https://trac.webkit.org/changeset/239988>

[Michael Catanzaro]

Committed r240226: <https://trac.webkit.org/changeset/240226>