Bug 193333 - WebDriver: update Create Browsing Context implementation to support newest specification
Summary: WebDriver: update Create Browsing Context implementation to support newest sp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 13:27 PST by BJ Burg
Modified: 2022-03-01 02:28 PST (History)
9 users (show)

See Also:

Attachments
Patch (12.71 KB, patch)
2019-01-10 14:11 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch (12.71 KB, patch)
2019-01-10 14:40 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
For Landing (15.13 KB, patch)
2019-01-11 11:45 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2019-01-10 13:27:19 PST 
.
Comment 1 BJ Burg 2019-01-10 13:27:33 PST 
<rdar://problem/45649489>
Comment 2 BJ Burg 2019-01-10 14:11:44 PST 
Created attachment 358833 [details]
Patch
Comment 3 BJ Burg 2019-01-10 14:31:47 PST 
Patch depends on https://bugs.webkit.org/show_bug.cgi?id=193331. I will tickle EWS once that lands via cq.
Comment 4 BJ Burg 2019-01-10 14:40:38 PST 
Created attachment 358837 [details]
Patch
Comment 5 Carlos Garcia Campos 2019-01-11 00:49:33 PST 
Comment on attachment 358837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review

This looks good to me. An apple reviewer might want to check the new API, though.

> Source/WebKit/UIProcess/Automation/Automation.json:335
>                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}

Should we change this now too? Using the enum too and renamed as presentationHint.
Comment 6 BJ Burg 2019-01-11 10:57:04 PST 
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.
> 
> > Source/WebKit/UIProcess/Automation/Automation.json:335
> >                  { "name": "preferNewTab", "type": "boolean", "optional": true, "description": "Create the new browsing context as a tab in an existing Automation window, if possible."}
> 
> Should we change this now too? Using the enum too and renamed as
> presentationHint.

Sure, we can do that.
Comment 7 BJ Burg 2019-01-11 11:44:24 PST 
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 358837 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358837&action=review
> 
> This looks good to me. An apple reviewer might want to check the new API,
> though.

Since I posted the patch, Wenson took a look and was okay with the changes.
Comment 8 BJ Burg 2019-01-11 11:45:27 PST 
Created attachment 358920 [details]
For Landing
Comment 9 BJ Burg 2019-01-15 09:15:50 PST 
Committed r239988: <https://trac.webkit.org/changeset/239988>
Comment 10 Michael Catanzaro 2019-01-20 21:09:40 PST 
Committed r240226: <https://trac.webkit.org/changeset/240226>