Bug 193331 - Web Inspector: incorrect type signature used for protocol enums in async command results
Summary: Web Inspector: incorrect type signature used for protocol enums in async comm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-10 12:29 PST by BJ Burg
Modified: 2019-01-10 14:38 PST (History)
11 users (show)

See Also:


Attachments
Patch (8.58 KB, patch)
2019-01-10 12:56 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2019-01-10 12:29:54 PST
Oops.
Comment 1 Devin Rousso 2019-01-10 12:47:19 PST
Can you give an example?
Comment 2 BJ Burg 2019-01-10 12:56:01 PST
Created attachment 358822 [details]
Patch
Comment 3 EWS Watchlist 2019-01-10 12:59:36 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Devin Rousso 2019-01-10 13:17:50 PST
Comment on attachment 358822 [details]
Patch

r=me, as you said "Oops." :P
Comment 5 WebKit Commit Bot 2019-01-10 14:37:05 PST
Comment on attachment 358822 [details]
Patch

Clearing flags on attachment: 358822

Committed r239846: <https://trac.webkit.org/changeset/239846>
Comment 6 WebKit Commit Bot 2019-01-10 14:37:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-10 14:38:29 PST
<rdar://problem/47190946>