Bug 193328 – Bindings generator emits incorrect code when using VoidCallback as an IDL dictionary attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Wenson Hsieh]

For instance, this IDL:

    dictionary Foo {
        required VoidCallback bar;
    };

...generates this code in the corresponding implementation of convertDictionary:

    if (!barValue.isUndefined()) {
        result.bar = convert<IDLCallbackFunction<JSVoidCallback>>(state, barValue, );
        RETURN_IF_EXCEPTION(throwScope, { });
    } else {
        throwRequiredMemberTypeError(state, throwScope, "bar", "FooInit", "VoidCallback");
        return { };
    }

...which (of course) fails to compile.

[Wenson Hsieh]

Created attachment 358816 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 358816 [details]
Patch

Clearing flags on attachment: 358816

Committed r239842: <https://trac.webkit.org/changeset/239842>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47189164>