Bug 193109 – Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

Work towards <rdar://problem/44807048>

[Wenson Hsieh]

Created attachment 358282 [details]
WIP

[Wenson Hsieh]

Created attachment 358847 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 358847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358847&action=review

> Source/WebCore/page/UndoItem.idl:35
> +    Constructor(DOMString label, UndoItemInit initDict)

We might wanna consider making label simply an attribute of UndoItemInit.

> Source/WebCore/page/UndoManager.h:37
> +class UndoManager : public RefCounted<UndoManager> {
> +public:

Maybe make it fast allocated & iso-heaped?

> Source/WebCore/page/UndoManager.h:43
> +    virtual ~UndoManager() = default;

I don't think we need this.
Just add ImplementationLacksVTable to IDL.

> Source/WebCore/page/UndoManager.idl:27
> +    EnabledAtRuntime=UndoManagerAPI

Add GenerateIsReachable=ImplDocument. Add a test if possible too.

> LayoutTests/ChangeLog:13
> +        * editing/undo/UndoManager/undo-manager-interfaces-expected.txt: Added.
> +        * editing/undo/UndoManager/undo-manager-interfaces.html: Added.

Why don't we just add it to editing/undo-manager/

[Ryosuke Niwa]

Comment on attachment 358847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358847&action=review

> Source/WebCore/page/UndoItem.idl:34
> +    EnabledAtRuntime=UndoManagerAPI,

In the future, you'd need to add JSCustomMarkFunction here,
then in JSUndoManagerCustom.cpp you need to invoke wrapped().callback().visitJSFunction in JSMutationObserver::visitAdditionalChildren.
Then you have to make these objects reachable from the document/frame...

[Wenson Hsieh]

Comment on attachment 358847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358847&action=review

Thanks for the review!

>> Source/WebCore/page/UndoItem.idl:34
>> +    EnabledAtRuntime=UndoManagerAPI,
> 
> In the future, you'd need to add JSCustomMarkFunction here,
> then in JSUndoManagerCustom.cpp you need to invoke wrapped().callback().visitJSFunction in JSMutationObserver::visitAdditionalChildren.
> Then you have to make these objects reachable from the document/frame...

Sounds good — I'll augment the next patch (for addItem support) with this change.

>> Source/WebCore/page/UndoItem.idl:35
>> +    Constructor(DOMString label, UndoItemInit initDict)
> 
> We might wanna consider making label simply an attribute of UndoItemInit.

Ok! I moved the label attribute into UndoItemInit.

>> Source/WebCore/page/UndoManager.h:37
>> +public:
> 
> Maybe make it fast allocated & iso-heaped?

👍

(Also did this to UndoItem)

>> Source/WebCore/page/UndoManager.h:43
>> +    virtual ~UndoManager() = default;
> 
> I don't think we need this.
> Just add ImplementationLacksVTable to IDL.

👍

(I also fixed this for UndoItem)

>> LayoutTests/ChangeLog:13
>> +        * editing/undo/UndoManager/undo-manager-interfaces.html: Added.
> 
> Why don't we just add it to editing/undo-manager/

👍

[Wenson Hsieh]

Comment on attachment 358847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358847&action=review

>> Source/WebCore/page/UndoManager.idl:27
>> +    EnabledAtRuntime=UndoManagerAPI
> 
> Add GenerateIsReachable=ImplDocument. Add a test if possible too.

👍 Fixed, and also added a test to verify that the wrapper survives GC.

[Wenson Hsieh]

Created attachment 358873 [details]
Patch for EWS

[Wenson Hsieh]

Comment on attachment 358873 [details]
Patch for EWS

It looks like commit queue is unresponsive :(

[Wenson Hsieh]

Committed <https://trac.webkit.org/changeset/239864/webkit>.