Bug 193279 - ComplexText: Test fast/text/word-space-nbsp.html fails when using complex text path
Summary: ComplexText: Test fast/text/word-space-nbsp.html fails when using complex tex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-09 05:26 PST by Carlos Garcia Campos
Modified: 2019-02-01 16:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2019-01-09 05:28 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-01-09 05:26:15 PST 
The fix applied in r135884 to WidthIterator should also be applied to ComplexTextController.
Comment 1 Carlos Garcia Campos 2019-01-09 05:28:21 PST 
Created attachment 358697 [details]
Patch
Comment 2 Myles C. Maxfield 2019-01-11 15:17:37 PST 
Comment on attachment 358697 [details]
Patch

Where's the test?
Comment 3 Michael Catanzaro 2019-01-11 17:23:50 PST 
Comment on attachment 358697 [details]
Patch

fast/text/word-space-nbsp.html? :)
Comment 4 Myles C. Maxfield 2019-01-11 17:42:54 PST 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 358697 [details]
> Patch
> 
> fast/text/word-space-nbsp.html? :)

Oh, it's not marked as failing yet?
Comment 5 Carlos Garcia Campos 2019-01-13 01:34:28 PST 
(In reply to Myles C. Maxfield from comment #4)
> (In reply to Michael Catanzaro from comment #3)
> > Comment on attachment 358697 [details]
> > Patch
> > 
> > fast/text/word-space-nbsp.html? :)
> 
> Oh, it's not marked as failing yet?

It started to fail when we switched to use complex text code path for layout tests, but we never marked it as failure:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239904%20(9360)/fast/text/word-space-nbsp-diffs.html
Comment 6 Michael Catanzaro 2019-01-21 12:35:55 PST 
Um... it's marked as failing now! (After bug #193628.)

Myles?
Comment 7 Michael Catanzaro 2019-01-21 12:36:27 PST 
(Patch should remove the failure expectation when landing, but no reason to block review on that.)
Comment 8 Carlos Garcia Campos 2019-01-30 06:09:31 PST 
Ping Myles.
Comment 9 Michael Catanzaro 2019-01-30 07:14:37 PST 
(In reply to Michael Catanzaro from comment #7)
> (Patch should remove the failure expectation when landing, but no reason to
> block review on that.)
Comment 10 Carlos Garcia Campos 2019-02-01 06:33:22 PST 
Committed r240846: <https://trac.webkit.org/changeset/240846>
Comment 11 Radar WebKit Bug Importer 2019-02-01 06:34:27 PST 
<rdar://problem/47734600>
Comment 12 Myles C. Maxfield 2019-02-01 16:34:36 PST 
Sorry for not getting to this in time.