Bug 193279 – ComplexText: Test fast/text/word-space-nbsp.html fails when using complex text path

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Carlos Garcia Campos]

The fix applied in r135884 to WidthIterator should also be applied to ComplexTextController.

[Carlos Garcia Campos]

Created attachment 358697 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 358697 [details]
Patch

Where's the test?

[Michael Catanzaro]

Comment on attachment 358697 [details]
Patch

fast/text/word-space-nbsp.html? :)

[Myles C. Maxfield]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 358697 [details]
> Patch
> 
> fast/text/word-space-nbsp.html? :)

Oh, it's not marked as failing yet?

[Carlos Garcia Campos]

(In reply to Myles C. Maxfield from comment #4)
> (In reply to Michael Catanzaro from comment #3)
> > Comment on attachment 358697 [details]
> > Patch
> > 
> > fast/text/word-space-nbsp.html? :)
> 
> Oh, it's not marked as failing yet?

It started to fail when we switched to use complex text code path for layout tests, but we never marked it as failure:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239904%20(9360)/fast/text/word-space-nbsp-diffs.html

[Michael Catanzaro]

Um... it's marked as failing now! (After bug #193628.)

Myles?

[Michael Catanzaro]

(Patch should remove the failure expectation when landing, but no reason to block review on that.)

[Carlos Garcia Campos]

Ping Myles.

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #7)
> (Patch should remove the failure expectation when landing, but no reason to
> block review on that.)

[Carlos Garcia Campos]

Committed r240846: <https://trac.webkit.org/changeset/240846>

[Radar WebKit Bug Importer]

<rdar://problem/47734600>

[Myles C. Maxfield]

Sorry for not getting to this in time.