Bug 101443 – REGRESSION (r125578): word-wrapping in absolute position with nbsp, word-spacing and custom font

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

In the example the div should only be one line of text, instead the line is wrapped.

Broken in WebKit Nightly 8536.26.17, 537+ and Chrome 23.0.1271.64
Works in Safari 6.0.2, Firefox 16.0 Mac, Opera 12.02 Mac, Chrome 22 Mac

Created attachment 172750 [details]
Example of the issue.

Also happens without the custom font. Probably a duplicate of bug 96856.

[Alexey Proskuryakov]

This seems to have been an intentional change, see <http://trac.webkit.org/changeset/125578>. However, bug 89826 does not mention any testing performed, so perhaps CSS spec is just wrong.

Why do you say that the new behavior is incorrect? Does the change break any live sites?

(In reply to comment #3)
> This seems to have been an intentional change, see <http://trac.webkit.org/changeset/125578>. However, bug 89826 does not mention any testing performed, so perhaps CSS spec is just wrong.
> 
> Why do you say that the new behavior is incorrect? Does the change break any live sites?

This is incorrect because the box should stretch to the maximum preferred width of its contents (regardless of how word-spacing factors into that width), but instead it falls short, so the text is forced to wrap. When the behavior of word-spacing was changed in r125578, supposedly for compliance with the spec, the maximum width calculation in RenderText was not updated, causing a discrepancy that leads to this bug.

> Also happens without the custom font.

You are right, I probably messed something up, custom font is not necessary to reproduce.

> Why do you say that the new behavior is incorrect? Does the change break any live sites?

Well, it breaks my site http://i.imgur.com/3pI6k.png but that's not a major problem. 

PS: Incidentally I just noticed on right on this page: http://i.imgur.com/3pI6k.png didn't check if related.

> PS: Incidentally I just noticed on right on this page …

Here's the correct link: http://i.imgur.com/SlFqz.png

[Robert Hogan]

Created attachment 173496 [details]
Patch

[Robert Hogan]

Hi Dan,

Can you review this please?

Thanks..

[Dave Hyatt]

Comment on attachment 173496 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 173496 [details]
Patch

Clearing flags on attachment: 173496

Committed r135884: <http://trac.webkit.org/changeset/135884>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.