Bug 193249 – Web Inspector: Event breakpoints: text field and completion popover fonts should match

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 358620 [details]
[Image] Bug

font-family and font-size should match. I suggest using "Menlo, monospace" as we always do for editable code.

The completion popover text should be directly under the text field text — not shifted a few pixels on the left.

[Devin Rousso]

Created attachment 358628 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 358628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review

Works as expected. I'd r+.

> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.css:42
> +    font-family: system-ui;

Interesting, we've never used "system-ui" before.

I had to look it up when we added this: https://bugs.webkit.org/show_bug.cgi?id=151493. It seems like we can replace "-webkit-system-font" with "system-ui" everywhere.

> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199
> +        rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight);

`rect.size.width` doesn't seem to be used by this._suggestionsView.show.

[Matt Baker]

Comment on attachment 358628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199
>> +        rect.size.width -= padding + parseInt(computedStyle.borderRightWidth) + parseInt(computedStyle.paddingRight);
> 
> `rect.size.width` doesn't seem to be used by this._suggestionsView.show.

This is an implementation detail; we could change the signature if we really wanted:

show(anchorOrigin, anchorHeight) or just show(origin, anchorHeight)

[WebKit Commit Bot]

Comment on attachment 358628 [details]
Patch

Clearing flags on attachment: 358628

Committed r239953: <https://trac.webkit.org/changeset/239953>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47266828>