Bug 151493 – Alias "system-ui" for the System font name

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Timothy Hatcher]

Per W3C minutes: "Resolved: Change system to system-ui in Fonts 4"

https://www.w3.org/blog/CSS/2015/11/19/minutes-telecon-267/

[Radar WebKit Bug Importer]

<rdar://problem/23629107>

[Myles C. Maxfield]

The old name can't stop working.

[Jon Lee]

Created attachment 301301 [details]
Patch

[Jon Lee]

submitted for EWS.

[Jon Lee]

We never supported "system", so removing that from the title.

[Jon Lee]

Created attachment 301322 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 301322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301322&action=review

What about styling list boxes? IIRC those are styled with CSS which means we would need somewhere to specify the system font.

This is the bug I was going to use for the expansion behavior to make "system-ui" expand to many fonts for the CT cascade list. If this one is just for the single font, do we have another but for that larger task?

> Source/WebCore/css/WebKitFontFamilyNames.in:8
> +systemUiFamily="-webkit-system-ui"

Why is this prefixed? We never shipped with -webkit-system-ui and we generally want to avoid unnecessary prefixes.

[Jon Lee]

Comment on attachment 301322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301322&action=review

>> Source/WebCore/css/WebKitFontFamilyNames.in:8
>> +systemUiFamily="-webkit-system-ui"
> 
> Why is this prefixed? We never shipped with -webkit-system-ui and we generally want to avoid unnecessary prefixes.

This file is used to generate a .cpp file that contains the symbols. I don't think the string is surfaced anywhere.

[Jon Lee]

(In reply to comment #7)
> Comment on attachment 301322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301322&action=review
> 
> What about styling list boxes? IIRC those are styled with CSS which means we
> would need somewhere to specify the system font.

It uses "-webkit-small-control".
 
> This is the bug I was going to use for the expansion behavior to make
> "system-ui" expand to many fonts for the CT cascade list. If this one is
> just for the single font, do we have another but for that larger task?
> 

Filed 168827.

[Jon Lee]

Created attachment 302660 [details]
Patch

[Jon Lee]

Removed unneeded changes to FontGenericFamilies, and added Web Inspector support.

[Tim Horton]

Comment on attachment 302660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302660&action=review

> Source/WebCore/ChangeLog:32
> [phone]  Jon Lee  <[e-mail]>

Double changelog.

> Source/WebInspectorUI/UserInterface/External/CodeMirror/css.js:666
> -    "subpixel-antialiased", "super", "sw-resize", "symbolic", "symbols", "table",
> +    "subpixel-antialiased", "super", "sw-resize", "symbolic", "symbols", "system-ui", "table",

Joe says not to modify this file, but instead file a bug on the upstream project.

[Jon Lee]

Committed r212985: <http://trac.webkit.org/changeset/212985>

[Frédéric Wang (:fredw)]

(In reply to Jon Lee from comment #8)
> Comment on attachment 301322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301322&action=review
> 
> >> Source/WebCore/css/WebKitFontFamilyNames.in:8
> >> +systemUiFamily="-webkit-system-ui"
> > 
> > Why is this prefixed? We never shipped with -webkit-system-ui and we generally want to avoid unnecessary prefixes.
> 
> This file is used to generate a .cpp file that contains the symbols. I don't
> think the string is surfaced anywhere.

I checked the three places where you actually used the symbol. Two of them seem dead code since the font-family names in font and @font-face parsing don't actually create a CSS ID value for system-ui.

The third one in compute style is web-exposed, see "Serialization of prefixed -webkit-<generic-family>" in https://w3c-test.org/css/cssom/font-family-serialization-001.html (set kGenericFontFamilyKeywords=["system-ui"] to test it).