We should use clean-webkit and update-webkit scripts to clean and update the webkit checkout. These scripts are more reliable than Buildbot default method. Buildbot updates the repo in a weird manner, and doesn't update the source completely. It only does a 'git fetch', not 'git pull'. It results in origin/master never being updated. Therefore 'git status' shows: "Your branch is ahead of 'origin/master' by x commits." This cause the Style checker to check for style error in all those past x commits and therefore failing. For e.g.: https://ews-build.webkit-uat.org/#/builders/5/builds/1001 fails with 18 style errors, even though that patch(358478) did not had any style error.
Created attachment 374821 [details] Patch
Attachment 374821 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:170: [UpdateWorkingDirectory.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1448: [TestUpdateWorkingDirectory.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1448: [TestUpdateWorkingDirectory.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1461: [TestUpdateWorkingDirectory.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1461: [TestUpdateWorkingDirectory.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 374825 [details] Patch
Attachment 374825 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:170: [UpdateWorkingDirectory.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:520: [CheckStyle.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1453: [TestUpdateWorkingDirectory.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1453: [TestUpdateWorkingDirectory.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1466: [TestUpdateWorkingDirectory.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1466: [TestUpdateWorkingDirectory.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sample runs: Style failure: https://ews-build.webkit-uat.org/#/builders/5/builds/4959 Pass: https://ews-build.webkit-uat.org/#/builders/5/builds/4958
Comment on attachment 374825 [details] Patch Clearing flags on attachment: 374825 Committed r247871: <https://trac.webkit.org/changeset/247871>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53664345>