Bug 201179 - [ews-build] Use update-webkit script in Apply-WatchList EWS
Summary: [ews-build] Use update-webkit script in Apply-WatchList EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-27 04:21 PDT by Aakash Jain
Modified: 2019-08-27 10:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2019-08-27 04:26 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-08-27 04:21:07 PDT 
Similar to https://bugs.webkit.org/show_bug.cgi?id=193196, we need to run Tools/Scripts/update-webkit for Apply-WatchList. update-webkit will do 'git pull'.

By default, Buildbot updates the repo in a weird manner, and doesn't update the source completely. It only does a 'git fetch', not 'git pull'. It results in origin/master never being updated. Therefore 'git status' shows: "Your branch is ahead of 'origin/master' by x commits."

This cause the apply-watchlist command to generate the incorrect cc list based on the previous commits as well.
Comment 1 Aakash Jain 2019-08-27 04:26:18 PDT 
Created attachment 377336 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-27 10:18:24 PDT 
Comment on attachment 377336 [details]
Patch

Clearing flags on attachment: 377336

Committed r249148: <https://trac.webkit.org/changeset/249148>
Comment 3 WebKit Commit Bot 2019-08-27 10:18:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-08-27 10:19:17 PDT 
<rdar://problem/54752732>