Bug 193025 – REGRESSION (r237269): webkit-patch what-broke is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

webkit-patch what-broke is broken following <https://trac.webkit.org/changeset/237269/> (bug #190732).

$ Tools/Scripts/webkit-patch what-broke
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queries.py", line 212, in execute
    builder_statuses = tool.buildbot.builder_statuses()
AttributeError: 'WebKitPatch' object has no attribute 'buildbot'

[Radar WebKit Bug Importer]

<rdar://problem/46974154>

[WebKit Commit Bot]

Created attachment 360921 [details]
Patch

[Daniel Bates]

Comment on attachment 360921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360921&action=review

> Tools/ChangeLog:1
> [phone]  Commit Queue  <[e-mail]>

It happened! AI is here! And I thought you were only capable of landing patches.

[WebKit Commit Bot]

Created attachment 360925 [details]
Patch

[Aakash Jain]

r+ after fixing the ChangeLog.

[WebKit Commit Bot]

Comment on attachment 360925 [details]
Patch

Clearing flags on attachment: 360925

Committed r240936: <https://trac.webkit.org/changeset/240936>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

(In reply to WebKit Commit Bot from comment #4)
> Created attachment 360925 [details]
> Patch

You're a bad bot. Now, you're impersonating someone else :/

[Daniel Bates]

(In reply to Daniel Bates from comment #8)
> (In reply to WebKit Commit Bot from comment #4)
> > Created attachment 360925 [details]
> > Patch
> 
> You're a bad bot. Now, you're impersonating someone else :/

Joking aside. Dean, hint, hint, hint.