Bug 190732 – clean-webkit pulls in many unnecessary dependencies in webkitpy

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dean Johnson]

Tools/Scripts/clean-webkit pulls in many unnecessary dependencies in webkitpy through creation of the Host object, which starts auto-installing 'bugzilla', 'buildbot' and 'web' packages. These can take a while to install, and are not needed at all if just trying to clean your checkout.

[Dean Johnson]

Created attachment 352727 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 352727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352727&action=review

> Tools/Scripts/webkitpy/common/host.py:63
> +    @property
> +    def bugs(self):
> +        if not hasattr(self, '_bugs'):
> +            from webkitpy.common.net import bugzilla
> +            self._bugs = bugzilla.Bugzilla()
> +        return self._bugs

I think that this would be better with @memoized.

@memoized
def bugs(self):
    return bugzilla.Bugzilla()

[Alexey Proskuryakov]

Well, also the import.

[Dean Johnson]

Created attachment 352732 [details]
Patch

[Dean Johnson]

Changed to use @memoized. Still need @property to access the functions as if they were a property, to allow class attributes 'bugzilla', 'buildbot', and 'web' to continue being used as they were.

[Alexey Proskuryakov]

Comment on attachment 352732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352732&action=review

> Tools/Scripts/webkitpy/common/host.py:58
> +    @property

Do we need @property here? Looks like @memoized tends to be used without.

[Alexey Proskuryakov]

Saw your explanation now.

[WebKit Commit Bot]

Comment on attachment 352732 [details]
Patch

Clearing flags on attachment: 352732

Committed r237269: <https://trac.webkit.org/changeset/237269>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45386267>

[Daniel Bates]

(In reply to WebKit Commit Bot from comment #8)
> Comment on attachment 352732 [details]
> Patch
> 
> Clearing flags on attachment: 352732
> 
> Committed r237269: <https://trac.webkit.org/changeset/237269>

This broke "webkit-patch what-broke". See bug #193025.