Bug 193024 - [lldb-webkit]: Add support for pretty-printing raw bitmask types
Summary: [lldb-webkit]: Add support for pretty-printing raw bitmask types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-24 16:43 PST by Daniel Bates
Modified: 2019-01-04 21:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.36 KB, patch)
2018-12-24 17:02 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (9.42 KB, patch)
2019-01-04 11:21 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-12-24 16:43:14 PST 
There are some types, like WebEventFlags, that must remain a plain-old enumeration as opposed to being turned into an OptionSet. We should support pretty printing such types.
Comment 1 Daniel Bates 2018-12-24 17:02:10 PST 
Created attachment 358050 [details]
Patch
Comment 2 Daniel Bates 2018-12-24 17:05:02 PST 
Note that the proposed patch (attachment #358050 [details]) includes the patch for bug #193023. I am hoping that people do not disagree with the fix for bug #193023. If they do, then I will fix up this patch as applicable.
Comment 3 Jer Noble 2019-01-04 10:02:30 PST 
Comment on attachment 358050 [details]
Patch

👍🏻
Comment 4 Daniel Bates 2019-01-04 11:21:20 PST 
Created attachment 358341 [details]
To Land
Comment 5 Daniel Bates 2019-01-04 21:03:37 PST 
Committed r239651: <https://trac.webkit.org/changeset/239651>
Comment 6 Radar WebKit Bug Importer 2019-01-04 21:08:29 PST 
<rdar://problem/47064007>