The WTF::OptionSet pretty printer contains code to print the value of WTF::OptionSet::m_storage. Due to an off-by-one error this code is broken and as a result we never print the value of WTF::OptionSet::m_storage when pretty printing the option set. Having said that, it does not seem very meaningful to print the value of m_storage as it is just the sum of the values of the enumerators in the set and I find it would just be noise if printed. We should just remove the code that tried to print WTF::OptionSet::m_storage. If there is someone that likes knowing m_storage then we should still remove the current code and re-implement this functionality as part of the summary string for WTF::OptionSet so that we do not print m_storage as if it was an item in the set. For completeness, if the code had worked then pretty printed output would look like: (WTF::OptionSet<ExampleFlags>) $0 = { size = 3 } { A = 1 C = 4 D = 8 m_storage = 13 } Currently it looks like: (WTF::OptionSet<ExampleFlags>) $0 = { size = 3 } { A = 1 C = 4 D = 8 }
Created attachment 358049 [details] Patch
Comment on attachment 358049 [details] Patch No tests?
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 358049 [details] > Patch > > No tests? No tests, because I am removing functionality.
Comment on attachment 358049 [details] Patch Clearing flags on attachment: 358049 Committed r239570: <https://trac.webkit.org/changeset/239570>
All reviewed patches have been landed. Closing bug.
<rdar://problem/47005480>