WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
192898
[iOS] uiController.keyDown() does not translate Control modified key
https://bugs.webkit.org/show_bug.cgi?id=192898
Summary
[iOS] uiController.keyDown() does not translate Control modified key
Daniel Bates
Reported
2018-12-19 16:39:50 PST
Key translation occurs with respect to the current keyboard layout when holding the Control key down and pressing a key. We need a way to do something similar so that we can use UIController.keyDown() to emulate Control modified key commands, such as Control + A. On a related note, we may want to consider exposing a way to specify a particular keyboard layout to use when running a test to ensure consistent results regardless of the current keyboard layout.
Attachments
Patch
(20.98 KB, patch)
2019-01-14 14:30 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2
(2.66 MB, application/zip)
2019-01-14 16:24 PST
,
EWS Watchlist
no flags
Details
Patch and layout tests
(22.06 KB, patch)
2019-01-15 10:40 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2
(9.26 MB, application/zip)
2019-01-15 12:26 PST
,
EWS Watchlist
no flags
Details
Patch and layout tests
(22.44 KB, patch)
2019-01-24 12:02 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2019-01-14 14:30:13 PST
Created
attachment 359080
[details]
Patch
EWS Watchlist
Comment 2
2019-01-14 16:24:20 PST
Comment hidden (obsolete)
Comment on
attachment 359080
[details]
Patch
Attachment 359080
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/10749691
New failing tests: fast/text/scroll-text-overflow-ellipsis.html
EWS Watchlist
Comment 3
2019-01-14 16:24:22 PST
Comment hidden (obsolete)
Created
attachment 359096
[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Daniel Bates
Comment 4
2019-01-15 10:40:22 PST
Created
attachment 359178
[details]
Patch and layout tests
EWS Watchlist
Comment 5
2019-01-15 12:26:44 PST
Comment hidden (obsolete)
Comment on
attachment 359178
[details]
Patch and layout tests
Attachment 359178
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/10761590
New failing tests: fast/text/scroll-text-overflow-ellipsis.html
EWS Watchlist
Comment 6
2019-01-15 12:26:46 PST
Comment hidden (obsolete)
Created
attachment 359191
[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Daniel Bates
Comment 7
2019-01-24 12:02:47 PST
Created
attachment 360024
[details]
Patch and layout tests
Wenson Hsieh
Comment 8
2019-01-24 15:07:36 PST
Comment on
attachment 360024
[details]
Patch and layout tests View in context:
https://bugs.webkit.org/attachment.cgi?id=360024&action=review
> LayoutTests/fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible-expected.html:7 > + /* Hide the tap highlight to mitigate test differences due to when the snapshot
Nice!
Daniel Bates
Comment 9
2019-01-25 14:35:14 PST
Comment on
attachment 360024
[details]
Patch and layout tests Clearing flags on attachment: 360024 Committed
r240512
: <
https://trac.webkit.org/changeset/240512
>
Daniel Bates
Comment 10
2019-01-25 14:35:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11
2019-01-25 14:36:33 PST
<
rdar://problem/47562134
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug