Bug 192897 - [iOS] Interpret text key commands on keydown and app key commands on keypress
Summary: [iOS] Interpret text key commands on keydown and app key commands on keypress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
: 191768 (view as bug list)
Depends on:
Blocks: 190571 193679
  Show dependency tree / graph
 
Reported: 2018-12-19 16:34 PST by Daniel Bates
Modified: 2019-01-22 13:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.40 KB, patch)
2018-12-19 16:51 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Layout test (once we fix bug #192898) (2.50 KB, text/html)
2018-12-19 16:52 PST, Daniel Bates 		no flags Details
To Land (8.16 KB, patch)
2019-01-08 17:00 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-12-19 16:34:57 PST 
To match Mac, we should interpret text key commands (e.g. Control + A) on keydown and app key commands (e.g. Command + F in Safari) on keypress.
Comment 1 Radar WebKit Bug Importer 2018-12-19 16:35:21 PST 
<rdar://problem/46857378>
Comment 2 Daniel Bates 2018-12-19 16:51:28 PST 
Created attachment 357755 [details]
Patch

I did not include  a test for this change since we need to fix bug #192898 in order to support testing Control-modified key commands. Will upload a test that we can use once bug #192898 is fixed. We no longer need to check that we are interpreting a keydown event before calling the SPI as the SPI does this check for us.
Comment 3 Daniel Bates 2018-12-19 16:52:11 PST 
Created attachment 357756 [details]
Layout test (once we fix bug #192898)
Comment 4 Daniel Bates 2018-12-19 16:54:23 PST 
Comment on attachment 357756 [details]
Layout test (once we fix bug #192898)

This layout test was written with the assumption that it would be placed in LayoutTests/fast/events/ios (or at least in a similar directory hierarchy).
Comment 5 Brent Fulgham 2019-01-04 12:55:23 PST 
Comment on attachment 357755 [details]
Patch

Looks good. Do we need any UIKit changes to support this before landing?
Comment 6 Daniel Bates 2019-01-07 16:14:39 PST 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 357755 [details]
> Patch
> 
> Looks good. Do we need any UIKit changes to support this before landing?

Yes, we need the fix for <rdar://problem/46854373>.
Comment 7 Daniel Bates 2019-01-08 17:00:17 PST 
Created attachment 358656 [details]
To Land
Comment 8 Daniel Bates 2019-01-16 19:01:47 PST 
*** Bug 191768 has been marked as a duplicate of this bug. ***
Comment 9 Daniel Bates 2019-01-22 12:59:56 PST 
Comment on attachment 358656 [details]
To Land

Clearing flags on attachment: 358656

Committed r240285: <https://trac.webkit.org/changeset/240285>
Comment 10 Daniel Bates 2019-01-22 12:59:58 PST 
All reviewed patches have been landed.  Closing bug.