Bug 192872 – Improve release-level page-load logging

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Keith Rollin]

There are a number of reported bugs that are difficult or impossible to track down with our current level of logging. Additionally, some software groups lower in the page-loading stack have requested logging sufficient for tracking a user-visible error message down to the requested resource that caused the message. Add more-comprehensive logging to address these issues/requests.

[Radar WebKit Bug Importer]

<rdar://problem/46850309>

[Keith Rollin]

Created attachment 357713 [details]
Patch

[Keith Rollin]

Created attachment 357718 [details]
Patch

[EWS Watchlist]

Comment on attachment 357718 [details]
Patch

Attachment 357718 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10478272

New failing tests:
http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html
imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html
fast/loader/form-submission-after-beforeunload-cancel.html

[EWS Watchlist]

Created attachment 357731 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 357718 [details]
Patch

Attachment 357718 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10478462

New failing tests:
fast/loader/form-submission-after-beforeunload-cancel.html

[EWS Watchlist]

Created attachment 357734 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 357718 [details]
Patch

Attachment 357718 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10478274

New failing tests:
fast/loader/form-submission-after-beforeunload-cancel.html

[EWS Watchlist]

Created attachment 357740 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Chris Dumez]

Comment on attachment 357718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357718&action=review

> Source/WebCore/loader/FrameLoader.cpp:3361
> +            shouldClose());

This is not safe to call for logging, this fires events.

[Keith Rollin]

Created attachment 357760 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 357760 [details]
Patch

Clearing flags on attachment: 357760

Committed r239457: <https://trac.webkit.org/changeset/239457>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Keith Rollin]

This patch caused a crash in WebResourceLoader::willSendRequest.

Fixed in Bug 192989.