Bug 192989 - Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223
Summary: Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-21 11:48 PST by Keith Rollin
Modified: 2018-12-21 12:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2018-12-21 11:56 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-12-21 11:48:55 PST 
willSendRequest is calling maybeLoadFallbackForRedirect, which can delete “this”. After that, some new logging code tries to access “this” and causes the crash.

<rdar://problem/46901747>
Comment 1 Keith Rollin 2018-12-21 11:56:23 PST 
Created attachment 357963 [details]
Patch
Comment 2 Chris Dumez 2018-12-21 12:00:07 PST 
Comment on attachment 357963 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-12-21 12:25:29 PST 
Comment on attachment 357963 [details]
Patch

Clearing flags on attachment: 357963

Committed r239514: <https://trac.webkit.org/changeset/239514>
Comment 4 WebKit Commit Bot 2018-12-21 12:25:31 PST 
All reviewed patches have been landed.  Closing bug.