We should clear IDB files between tests to give each test a clean state.
Created attachment 357526 [details] Patch
Comment on attachment 357526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357526&action=review > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:520 > +void WKWebsiteDataStoreRemoveAllIndexedDatabasesSync(WKWebsiteDataStoreRef dataStoreRef, void* context, WKWebsiteDataStoreRemoveAllIndexedDatabasesCallback callback) Why does this have "Sync" in its name?
Comment on attachment 357526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357526&action=review >> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:520 >> +void WKWebsiteDataStoreRemoveAllIndexedDatabasesSync(WKWebsiteDataStoreRef dataStoreRef, void* context, WKWebsiteDataStoreRemoveAllIndexedDatabasesCallback callback) > > Why does this have "Sync" in its name? Since this function uses a callback, it is not synchronous. So, let's call this "WKWebsiteDataStoreRemoveAllIndexedDatabases".
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 357526 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357526&action=review > > >> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:520 > >> +void WKWebsiteDataStoreRemoveAllIndexedDatabasesSync(WKWebsiteDataStoreRef dataStoreRef, void* context, WKWebsiteDataStoreRemoveAllIndexedDatabasesCallback callback) > > > > Why does this have "Sync" in its name? > > Since this function uses a callback, it is not synchronous. So, let's call > this "WKWebsiteDataStoreRemoveAllIndexedDatabases". Yes, I guess because it's used with runUntil so I used sync.. Will change to WKWebsiteDataStoreRemoveAllIndexedDatabases
Created attachment 357586 [details] Patch
Comment on attachment 357586 [details] Patch r=me
Created attachment 357620 [details] Patch for landing
Comment on attachment 357620 [details] Patch for landing Clearing flags on attachment: 357620 Committed r239358: <https://trac.webkit.org/changeset/239358>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46824999>
It appears that after https://trac.webkit.org/changeset/239358/webkit we are seeing a large number of imported/w3c/web-platform-tests/IndexedDB/ tests crashing on debug wk2 bots with asserts. Sample log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r239376%20(954)/imported/w3c/web-platform-tests/IndexedDB/close-in-upgradeneeded-crash-log.txt results from Mojave Debug Wk2: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r239376%20(954)/results.html
also looks like this caused two perf test failures: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Perf%29/builds/2381
Reverted r239358 for reason: Revision caused imported/w3c/web-platform-tests/IndexedDB/ to crash on Debug bots Committed r239380: <https://trac.webkit.org/changeset/239380>
rolled out in https://trac.webkit.org/changeset/239380/webkit
Created attachment 359785 [details] Patch
Comment on attachment 359785 [details] Patch r=me
Comment on attachment 359785 [details] Patch Attachment 359785 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10847394 New failing tests: imported/w3c/web-platform-tests/IndexedDB/idbfactory-open-request-error.html
Created attachment 359820 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 359821 [details] Patch
Comment on attachment 359821 [details] Patch r=me
Comment on attachment 359821 [details] Patch Clearing flags on attachment: 359821 Committed r240358: <https://trac.webkit.org/changeset/240358>