Bug 192693 – [Win][Clang] Fix compilation warnings under Source/WebCore/platform/win

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

[Win][Clang] Fix compilation warnings under Source/WebCore/platform/win

clang-cl reports the following compilation warnings.

> ..\..\Source\WebCore\platform\win\DefWndProcWindowClass.cpp(48,17):  warning: unused variable 'atom' [-Wunused-variable]
> ..\..\Source\WebCore\platform\win\PlatformMouseEventWin.cpp(87,7):  warning: field 'm_didActivateWebView' will be initialized after field 'm_modifierFlags' [-Wreorder]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(173,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(179,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(185,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(191,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(197,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(203,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(209,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(215,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(227,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(244,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(254,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\CursorWin.cpp(257,45):  warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\ClipboardUtilitiesWin.cpp(702,101):  warning: field 'format' will be initialized after field 'getString' [-Wreorder]
> ..\..\Source\WebCore\platform\win\DragImageWin.cpp(99,13):  warning: unused variable 'MinDragLabelWidthBeforeClip' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(45,18):  warning: 'show' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(46,18):  warning: 'hide' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(47,18):  warning: 'updateFromElement' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(48,18):  warning: 'disconnectClient' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(612,9):  warning: unused variable 'itemCount' [-Wunused-variable]
> ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(826,11):  warning: unused variable 'smoothScrollAnimationDuration' [-Wunused-const-variable]
> ..\..\Source\WebCore\platform\win\PasteboardWin.cpp(891,13):  warning: unused variable 'hr' [-Wunused-variable]
> ..\..\Source\WebCore\platform\win\PasteboardWin.cpp(1018,12):  warning: cast from 'DROPFILES *' (aka '_DROPFILES *') to 'LPWSTR' (aka 'wchar_t *') increases required alignment from 1 to 2 [-Wcast-align]
> ..\..\Source\WebCore\platform\win\DragImageCairoWin.cpp(125,9):  warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto]
> ..\..\Source\WebCore\platform\win\DragImageCairoWin.cpp(120,9):  warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto]
> ..\..\Source\WebCore\platform\win/StructuredExceptionHandlerSuppressor.h(48,11):  warning: private field 'm_savedExceptionRegistration' is not used [-Wunused-private-field]
> ..\..\Source\WebCore\platform\win\SSLKeyGeneratorWin.cpp(32,15):  warning: extra qualification on member 'getSupportedKeySizes' [-Wextra-qualification]
> ..\..\Source\WebCore\platform\win\SSLKeyGeneratorWin.cpp(38,17):  warning: extra qualification on member 'signedPublicKeyAndChallengeString' [-Wextra-qualification]
> ..\..\Source\WebCore\platform\win\SSLKeyGeneratorWin.cpp(65,43):  warning: ISO C++11 does not allow conversion from string literal to 'LPWSTR' (aka 'wchar_t *') [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\SSLKeyGeneratorWin.cpp(75,29):  warning: ISO C++11 does not allow conversion from string literal to 'LPSTR' (aka 'char *') [-Wwritable-strings]
> ..\..\Source\WebCore\platform\win\SystemInfo.cpp(83,13):  warning: 10 enumeration values not handled in switch: 'WindowsCE5', 'WindowsCE6', 'WindowsCE7'... [-Wswitch]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(45,18):  warning: 'show' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(46,18):  warning: 'hide' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(47,18):  warning: 'updateFromElement' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win/PopupMenuWin.h(48,18):  warning: 'disconnectClient' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> ..\..\Source\WebCore\platform\win\SearchPopupMenuDB.cpp(286,9):  warning: unused variable 'ret' [-Wunused-variable]

[Fujii Hironori]

Created attachment 357299 [details]
Patch

[Ross Kirsling]

Comment on attachment 357299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357299&action=review

> Source/WebCore/ChangeLog:31
> +        (WebCore::osVersionForUAString): Added defalut case.

Nit: "default"

> Source/WebCore/platform/win/PopupMenuWin.cpp:612
> -    // listRect is the damageRect translated into the coordinates of the entire menu list (which is itemCount * m_itemHeight pixels tall)
> +    // listRect is the damageRect translated into the coordinates of the entire menu list (which is itemSize * m_itemHeight pixels tall)

Did you mean "listSize"? I don't see an "itemSize"...

[Fujii Hironori]

Comment on attachment 357299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357299&action=review

>> Source/WebCore/platform/win/PopupMenuWin.cpp:612
>> +    // listRect is the damageRect translated into the coordinates of the entire menu list (which is itemSize * m_itemHeight pixels tall)
> 
> Did you mean "listSize"? I don't see an "itemSize"...

Oh, that's right. Thanks.

[Fujii Hironori]

Created attachment 357305 [details]
Patch for landing

[Fujii Hironori]

Comment on attachment 357305 [details]
Patch for landing

Clearing flags on attachment: 357305

Committed r239201: <https://trac.webkit.org/changeset/239201>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46723806>