Bug 192688 – [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Fujii Hironori]

clang-cl reports the following warnings:

> [1514/6308] Building CXX object Source\JavaScriptCore\shell\CMakeFiles\testRegExp.dir\DLLLauncherMain.cpp.obj
> ..\..\Source\JavaScriptCore\shell\DLLLauncherMain.cpp(83,21):  warning: unused function 'appleApplicationSupportDirectory' [-Wunused-function]
> static std::wstring appleApplicationSupportDirectory()
>                     ^
> ..\..\Source\JavaScriptCore\shell\DLLLauncherMain.cpp(99,13):  warning: unused function 'prependPath' [-Wunused-function]
> static bool prependPath(const std::wstring& directoryToPrepend)
>             ^
> 2 warnings generated.


> [4750/6308] Building CXX object Tools\ImageDiff\CMakeFiles\ImageDiff.dir\__\win\DLLLauncher\DLLLauncherMain.cpp.obj
> ..\..\Tools\win\DLLLauncher\DLLLauncherMain.cpp(82,16):  warning: unused function 'appleApplicationSupportDirectory' [-Wunused-function]
> static wstring appleApplicationSupportDirectory()
>                ^
> ..\..\Tools\win\DLLLauncher\DLLLauncherMain.cpp(98,13):  warning: unused function 'prependPath' [-Wunused-function]
> static bool prependPath(const wstring& directoryToPrepend)
>             ^
> 2 warnings generated.

[Fujii Hironori]

Created attachment 357291 [details]
Patch

[Ross Kirsling]

Comment on attachment 357291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357291&action=review

> Source/JavaScriptCore/shell/DLLLauncherMain.cpp:102
> +#if !defined(WIN_CAIRO)
>  static bool prependPath(const std::wstring& directoryToPrepend)

Might be nice to rearrange so that we don't need to add two #if blocks, but it's your call.

[Fujii Hironori]

Created attachment 357301 [details]
Patch for landing

[Fujii Hironori]

Comment on attachment 357301 [details]
Patch for landing

Clearing flags on attachment: 357301

Committed r239200: <https://trac.webkit.org/changeset/239200>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.