Bug 192672 - WebP image format is not supported
Summary: WebP image format is not supported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: Safari 12
Hardware: All All
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-13 11:47 PST by Michael Flores
Modified: 2020-02-13 14:01 PST (History)
11 users (show)

See Also:

Attachments
Patch (13.50 KB, patch)
2020-01-29 19:35 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (13.49 KB, patch)
2020-02-12 17:05 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Flores 2018-12-13 11:47:42 PST 
I'd like Webkit to consider supporting WebP images because of the benefits in load-time that developers can take advantage of.
Comment 1 Said Abou-Hallawa 2019-12-19 13:44:03 PST 
<rdar://problem/8509491>
Comment 2 Said Abou-Hallawa 2020-01-29 19:35:13 PST 
Created attachment 389221 [details]
Patch
Comment 3 youenn fablet 2020-01-30 00:39:22 PST 
Comment on attachment 389221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review

> LayoutTests/platform/mac/TestExpectations:1798
> +[ Catalina+ ] fast/images/animated-webp-as-image.html [ Pass ]

Should we have similar expectations for iOS?
Comment 4 Simon Fraser (smfr) 2020-01-30 10:38:42 PST 
Comment on attachment 389221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review

Do we need a canvas image encoding test?

> Source/WebCore/platform/MIMETypeRegistry.cpp:86
> +        "image/webp"_s,

You put this in the "// This represents the subset of allowed image UTIs for which CoreServices has a corresponding MIME type." section. Is that right at this point?
Comment 5 Said Abou-Hallawa 2020-02-12 16:41:44 PST 
<rdar://problem/59406585>
Comment 6 Said Abou-Hallawa 2020-02-12 17:05:24 PST 
Created attachment 390592 [details]
Patch
Comment 7 Said Abou-Hallawa 2020-02-12 17:29:42 PST 
Comment on attachment 389221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review

>> Source/WebCore/platform/MIMETypeRegistry.cpp:86
>> +        "image/webp"_s,
> 
> You put this in the "// This represents the subset of allowed image UTIs for which CoreServices has a corresponding MIME type." section. Is that right at this point?

Yes. #if HAVE(WEBP) is true, CoreServices will have the corresponding MIME type.

>> LayoutTests/platform/mac/TestExpectations:1798
>> +[ Catalina+ ] fast/images/animated-webp-as-image.html [ Pass ]
> 
> Should we have similar expectations for iOS?

Currently there is no way to specify a passing iOS version on EWS. The test has to be disabled completely and then enabled when EWS has the passing iOS version.
Comment 8 WebKit Commit Bot 2020-02-12 21:53:39 PST 
Comment on attachment 390592 [details]
Patch

Clearing flags on attachment: 390592

Committed r256501: <https://trac.webkit.org/changeset/256501>
Comment 9 WebKit Commit Bot 2020-02-12 21:53:40 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Said Abou-Hallawa 2020-02-13 11:17:52 PST 
A follow up patch to disable the new layout tests on Catalina:

Committed r256526: <https://trac.webkit.org/changeset/256526>