RESOLVED FIXED 192672
WebP image format is not supported 
https://bugs.webkit.org/show_bug.cgi?id=192672
Summary WebP image format is not supported
Michael Flores
Reported 2018-12-13 11:47:42 PST
I'd like Webkit to consider supporting WebP images because of the benefits in load-time that developers can take advantage of.
Attachments
Patch (13.50 KB, patch)
2020-01-29 19:35 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (13.49 KB, patch)
2020-02-12 17:05 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-12-19 13:44:03 PST
<rdar://problem/8509491>
Said Abou-Hallawa
Comment 2 2020-01-29 19:35:13 PST
Created attachment 389221 [details] Patch
youenn fablet
Comment 3 2020-01-30 00:39:22 PST
Comment on attachment 389221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review > LayoutTests/platform/mac/TestExpectations:1798 > +[ Catalina+ ] fast/images/animated-webp-as-image.html [ Pass ] Should we have similar expectations for iOS?
Simon Fraser (smfr)
Comment 4 2020-01-30 10:38:42 PST
Comment on attachment 389221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review Do we need a canvas image encoding test? > Source/WebCore/platform/MIMETypeRegistry.cpp:86 > + "image/webp"_s, You put this in the "// This represents the subset of allowed image UTIs for which CoreServices has a corresponding MIME type." section. Is that right at this point?
Said Abou-Hallawa
Comment 5 2020-02-12 16:41:44 PST
<rdar://problem/59406585>
Said Abou-Hallawa
Comment 6 2020-02-12 17:05:24 PST
Created attachment 390592 [details] Patch
Said Abou-Hallawa
Comment 7 2020-02-12 17:29:42 PST
Comment on attachment 389221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389221&action=review >> Source/WebCore/platform/MIMETypeRegistry.cpp:86 >> + "image/webp"_s, > > You put this in the "// This represents the subset of allowed image UTIs for which CoreServices has a corresponding MIME type." section. Is that right at this point? Yes. #if HAVE(WEBP) is true, CoreServices will have the corresponding MIME type. >> LayoutTests/platform/mac/TestExpectations:1798 >> +[ Catalina+ ] fast/images/animated-webp-as-image.html [ Pass ] > > Should we have similar expectations for iOS? Currently there is no way to specify a passing iOS version on EWS. The test has to be disabled completely and then enabled when EWS has the passing iOS version.
WebKit Commit Bot
Comment 8 2020-02-12 21:53:39 PST
Comment on attachment 390592 [details] Patch Clearing flags on attachment: 390592 Committed r256501: <https://trac.webkit.org/changeset/256501>
WebKit Commit Bot
Comment 9 2020-02-12 21:53:40 PST
All reviewed patches have been landed. Closing bug.
Said Abou-Hallawa
Comment 10 2020-02-13 11:17:52 PST
A follow up patch to disable the new layout tests on Catalina: Committed r256526: <https://trac.webkit.org/changeset/256526>
Note You need to log in before you can comment on or make changes to this bug.