Bug 192639 - REGRESSION (r230064): Focus rings on webpages are fainter than in native UI
Summary: REGRESSION (r230064): Focus rings on webpages are fainter than in native UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified macOS 10.14
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-12 14:32 PST by Timothy Hatcher
Modified: 2018-12-13 11:56 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.21 KB, patch)
2018-12-13 10:59 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-12-12 14:32:25 PST 
Focus ring color is expected to be opaque, since opacity used a paint time.

We we getting this by accident before when the old RenderThemeMac::systemColor() used convertNSColorToColor(), which ignored alpha on NSColor.
Comment 1 Timothy Hatcher 2018-12-12 14:32:36 PST 
<rdar://problem/42669297>
Comment 2 Radar WebKit Bug Importer 2018-12-12 14:33:34 PST 
<rdar://problem/46675739>
Comment 3 Timothy Hatcher 2018-12-12 14:38:03 PST 
<rdar://problem/42669297>
Comment 4 Timothy Hatcher 2018-12-13 10:59:41 PST 
Created attachment 357239 [details]
Patch
Comment 5 WebKit Commit Bot 2018-12-13 11:56:07 PST 
The commit-queue encountered the following flaky tests while processing attachment 357239 [details]:

imported/w3c/web-platform-tests/FileAPI/idlharness.worker.html bug 192673
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2018-12-13 11:56:52 PST 
Comment on attachment 357239 [details]
Patch

Clearing flags on attachment: 357239

Committed r239173: <https://trac.webkit.org/changeset/239173>
Comment 7 WebKit Commit Bot 2018-12-13 11:56:53 PST 
All reviewed patches have been landed.  Closing bug.