Bug 192581 – [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Fujii Hironori]

[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]

clang-cl reports the following compilation warnings:

> [5697/6307] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebKitPrefix.cpp.obj
> In file included from <built-in>:1:
> In file included from ..\..\Source\WebKitLegacy\win\WebKitPrefix.h:46:
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(1571,99):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
> extern const GUID  __declspec(selectany) SID_AccessibleComparable = { 0x62b8cb5f, 0xfb7a, 0x4faf, 0x81, 0xe8, 0x52, 0xb6, 0x5f, 0x12, 0x8b, 0x31 };
>                                                                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                                                                                   {                                             }
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(23610,43):  warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
>                                           ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(23188,43):  note: hidden overloaded virtual function 'IWebEditingDelegate::shouldInsertNode' declared here: different number of parameters (4 vs 5)
>         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
>                                           ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(46015,43):  warning: 'IWebViewPrivate2::addUserScriptToGroup' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
>                                           ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(45046,43):  note: hidden overloaded virtual function 'IWebViewPrivate::addUserScriptToGroup' declared here: different number of parameters (9 vs 10)
>         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
>                                           ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(46027,43):  warning: 'IWebViewPrivate2::addUserStyleSheetToGroup' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
>                                           ^
> DerivedSources\WebKitLegacy\Interfaces\WebKit.h(45057,43):  note: hidden overloaded virtual function 'IWebViewPrivate::addUserStyleSheetToGroup' declared here: different number of parameters (8 vs 9)
>         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
>                                           ^
> 4 warnings generated.

[Fujii Hironori]

Created attachment 357039 [details]
Patch

[Fujii Hironori]

Comment on attachment 357039 [details]
Patch

Clearing flags on attachment: 357039

Committed r239097: <https://trac.webkit.org/changeset/239097>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46651605>

[Fujii Hironori]

This isn't a right fix.
DumpRenderTree, MiniBrowser and TestWebKitAPI are still reporting the same warning.

> [4768/5007] Building CXX object Tools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\win\DRTDesktopNotificationPresenter.cpp.obj
> In file included from ..\..\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.cpp:33:
> In file included from ..\..\Tools\DumpRenderTree\win/DRTDesktopNotificationPresenter.h:32:
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(23600,43): warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
>                                           ^
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(23178,43): note: hidden overloaded virtual function 'IWebEditingDelegate::shouldInsertNode' declared here: different number of parameters (4 vs 5)
>         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
>                                           ^
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(46133,43): warning: 'IWebViewPrivate2::addUserScriptToGroup' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
>                                           ^
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(45164,43): note: hidden overloaded virtual function 'IWebViewPrivate::addUserScriptToGroup' declared here: different number of parameters (9 vs 10)
>         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
>                                           ^
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(46145,43): warning: 'IWebViewPrivate2::addUserStyleSheetToGroup' hides overloaded virtual function [-Woverloaded-virtual]
>         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
>                                           ^
> WebKitLegacy\Headers\WebKitLegacy/WebKit.h(45175,43): note: hidden overloaded virtual function 'IWebViewPrivate::addUserStyleSheetToGroup' declared here: different number of parameters (8 vs 9)
>         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
>                                           ^
> 3 warnings generated.

[Fujii Hironori]

Committed r249750: <https://trac.webkit.org/changeset/249750>

[Fujii Hironori]

Reverted.

[Fujii Hironori]

Created attachment 378531 [details]
Patch

[Alex Christensen]

We probably don't want to ignore that warning globally.  Can't we just #pragma clang our way around it for this one file?

[Fujii Hironori]

Created attachment 378533 [details]
Patch

How about this patch?

[Fujii Hironori]

Comment on attachment 378533 [details]
Patch

Clearing flags on attachment: 378533

Committed r249755: <https://trac.webkit.org/changeset/249755>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.