Bug 192398 - Minor refactoring of the scrolling code
Summary: Minor refactoring of the scrolling code
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
Keywords: InRadar
Depends on:
Blocks: 176914 192395
  Show dependency treegraph
Reported: 2018-12-05 05:37 PST by Frédéric Wang (:fredw)
Modified: 2019-01-22 08:59 PST (History)
3 users (show)

See Also:

Patch (11.29 KB, patch)
2018-12-05 05:44 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-12-05 05:37:05 PST
Minor refactoring of the scrolling tree
Comment 1 Frédéric Wang (:fredw) 2018-12-05 05:44:08 PST
Created attachment 356598 [details]
Comment 2 Simon Fraser (smfr) 2018-12-05 10:21:00 PST
Comment on attachment 356598 [details]

Clearing flags on attachment: 356598

Committed r238898: <https://trac.webkit.org/changeset/238898>
Comment 3 Simon Fraser (smfr) 2018-12-05 10:21:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-05 10:22:32 PST
Comment 5 Frédéric Wang (:fredw) 2019-01-22 08:51:56 PST
Comment on attachment 356598 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=356598&action=review

> Source/WebCore/page/scrolling/ScrollingStateTree.h:37
> +class ScrollingStateFrameScrollingNode;

I think this has caused ScrollingStateScrollingNode.h from not being included from ScrollingTreeScrollingNode.cpp, hence possible build error when unified sources rotate. Will land a fix.
Comment 6 Frédéric Wang (:fredw) 2019-01-22 08:59:22 PST
Committed r240252: <https://trac.webkit.org/changeset/240252>