Bug 192395 – Allow control over child order when adding nodes to the scrolling tree

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Simon Fraser (smfr)]

Allow control over child order when adding nodes to the scrolling tree

[Simon Fraser (smfr)]

Created attachment 356581 [details]
Patch

[EWS Watchlist]

Comment on attachment 356581 [details]
Patch

Attachment 356581 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10274669

New failing tests:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state.html

[EWS Watchlist]

Created attachment 356584 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Frédéric Wang (:fredw)]

This seems similar to what I tried in https://bugs.webkit.org/attachment.cgi?id=327061&action=review

[Frédéric Wang (:fredw)]

Trying to fix the EWS build error on iOS:

https://trac.webkit.org/changeset/238889/webkit

[Frédéric Wang (:fredw)]

Created attachment 356589 [details]
Patch (same as 356581)

resending to EWS

[EWS Watchlist]

Comment on attachment 356589 [details]
Patch (same as 356581)

Attachment 356589 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10275650

New failing tests:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state.html

[EWS Watchlist]

Created attachment 356591 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 356589 [details]
Patch (same as 356581)

Attachment 356589 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10275657

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 356592 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Frédéric Wang (:fredw)]

Comment on attachment 356589 [details]
Patch (same as 356581)

View in context: https://bugs.webkit.org/attachment.cgi?id=356589&action=review

> Source/WebCore/page/scrolling/ScrollingStateTree.h:-30
> -#include "ScrollingStateFrameScrollingNode.h"

OK, I thought what I fixed in comment 5 was again due to rotating unified build but it seems it was actually this change. I guess several cleanup changes in this patch could be handled outside to facilitate review.

> Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:416
> +        m_scrollingStateTree->attachNode(nodeType, nodeID, parentNodeID, i);

This seems wrong since numNodes is the size of the whole scrolling state tree not of the child list. I guess that's why I had tried to encode the child index in https://bugs.webkit.org/attachment.cgi?id=327061&action=review

[Frédéric Wang (:fredw)]

Created attachment 356599 [details]
Attachment 356581 [details], rebased on top of bug 192398

This is the patch rebased on top of bug 192398, but I think my comment 11 regarding RemoteScrollingCoordinatorTransaction still holds.

[Simon Fraser (smfr)]

Sorry for the duplicate patch; let's work on your version.

*** This bug has been marked as a duplicate of bug 176914 ***

[Frédéric Wang (:fredw)]

(In reply to Simon Fraser (smfr) from comment #13)
> Sorry for the duplicate patch; let's work on your version.
> 
> *** This bug has been marked as a duplicate of bug 176914 ***

OK, my patch is from one year ago though so probably we could just work from your version. BTW, I extracted the minor refactoring parts in bug 192398.