RESOLVED FIXED 192362
ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing 
https://bugs.webkit.org/show_bug.cgi?id=192362
Summary ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is fa...
Chris Dumez
Reported 2018-12-04 09:24:24 PST
ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing on the bots since it was introduced in r238828.
Attachments
Patch (1.70 KB, patch)
2018-12-04 10:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.95 KB, patch)
2018-12-06 08:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2018-12-07 10:28 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-12-04 10:43:20 PST
Created attachment 356515 [details] Patch
Chris Dumez
Comment 2 2018-12-04 11:44:51 PST
Comment on attachment 356515 [details] Patch Clearing flags on attachment: 356515 Committed r238868: <https://trac.webkit.org/changeset/238868>
Chris Dumez
Comment 3 2018-12-04 11:44:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-04 11:45:41 PST
<rdar://problem/46460360>
Ryan Haddad
Comment 5 2018-12-05 10:32:51 PST
This test is still failing as of r238893: https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/1362 TestWebKitAPI.ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing Received data during response processing, queuing it. /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3045 Expected equality of these values: @"foo=bar" Which is: "foo=bar" receivedMessages.get()[0] Which is: ""
Ryan Haddad
Comment 6 2018-12-05 10:35:14 PST
(In reply to Ryan Haddad from comment #5) > This test is still failing as of r238893: > https://build.webkit.org/builders/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/1362 This is limited to iOS bots.
Chris Dumez
Comment 7 2018-12-05 12:27:27 PST
(In reply to Ryan Haddad from comment #6) > (In reply to Ryan Haddad from comment #5) > > This test is still failing as of r238893: > > https://build.webkit.org/builders/ > > Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/1362 > This is limited to iOS bots. The issue does not reproduce on my iOS simulator for some reason..
Chris Dumez
Comment 8 2018-12-06 08:38:29 PST
Created attachment 356734 [details] Patch
Chris Dumez
Comment 9 2018-12-07 10:28:22 PST
Created attachment 356820 [details] Patch
Chris Dumez
Comment 10 2018-12-07 15:17:51 PST
ping review? This is keeping the bots red.
WebKit Commit Bot
Comment 11 2018-12-07 15:56:15 PST
Comment on attachment 356820 [details] Patch Clearing flags on attachment: 356820 Committed r238972: <https://trac.webkit.org/changeset/238972>
WebKit Commit Bot
Comment 12 2018-12-07 15:56:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.