Bug 192337 – Regression(PSON) Google OAuth is broken in private sessions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Google OAuth is broken in private sessions when enabling PSON.

[Chris Dumez]

<rdar://problem/46353558>

[Chris Dumez]

Created attachment 356418 [details]
Patch

[Alex Christensen]

Comment on attachment 356418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356418&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:121
> +    enum class BeginsUsingDataStore { No, Yes };

: bool

> Source/WebKit/UIProcess/WebProcessProxy.h:124
> +    enum class EndsUsingDataStore { No, Yes };

: bool

[Chris Dumez]

Created attachment 356420 [details]
Patch

[Chris Dumez]

Created attachment 356429 [details]
Patch

[Chris Dumez]

Comment on attachment 356429 [details]
Patch

Clearing flags on attachment: 356429

Committed r238828: <https://trac.webkit.org/changeset/238828>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

The API test added in this change is failing on macOS and iOS bots:

    TestWebKitAPI.ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing
        Received data during response processing, queuing it.
        LEAK: 1 WebProcessPool
        
        /Volumes/Data/slave/highsierra-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3045
        Expected equality of these values:
          @"foo=bar"
            Which is: "foo=bar"
          receivedMessages.get()[0]
            Which is: ""

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/5800/steps/run-api-tests/logs/stdio

[Chris Dumez]

(In reply to Ryan Haddad from comment #8)
> The API test added in this change is failing on macOS and iOS bots:
> 
>    
> TestWebKitAPI.ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing
>         Received data during response processing, queuing it.
>         LEAK: 1 WebProcessPool
>         
>        
> /Volumes/Data/slave/highsierra-debug/build/Tools/TestWebKitAPI/Tests/
> WebKitCocoa/ProcessSwapOnNavigation.mm:3045
>         Expected equality of these values:
>           @"foo=bar"
>             Which is: "foo=bar"
>           receivedMessages.get()[0]
>             Which is: ""
> 
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/5800/steps/run-api-
> tests/logs/stdio

I am investigating via Bug 192362.