Bug 192306 - [SOUP] Move URLSoup back to WebCore after r238771
Summary: [SOUP] Move URLSoup back to WebCore after r238771
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-12-03 03:10 PST by Carlos Garcia Campos
Modified: 2018-12-04 03:03 PST (History)
6 users (show)

See Also:


Attachments
Patch (33.63 KB, patch)
2018-12-03 03:19 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-12-03 03:10:57 PST
In r238771 URL was moved from WebCore to WTF, including the soup implementation. Unfortunately that added libsoup as a new dependency of libjavascriptcoregtk.
Comment 1 Carlos Garcia Campos 2018-12-03 03:19:47 PST
Created attachment 356372 [details]
Patch
Comment 2 Michael Catanzaro 2018-12-03 11:56:20 PST
Comment on attachment 356372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356372&action=review

Thanks, good catch. Looks like this was not fun to fix.

> Source/WebKit/PluginProcess/PluginProcess.cpp:42
> +#include <unistd.h>

Probably this belongs inside an OS(UNIX) guard.
Comment 3 Alex Christensen 2018-12-03 13:14:37 PST
LGTM.
Comment 4 Carlos Garcia Campos 2018-12-04 03:01:25 PST
Committed r238851: <https://trac.webkit.org/changeset/238851>
Comment 5 Radar WebKit Bug Importer 2018-12-04 03:03:29 PST
<rdar://problem/46448678>