WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 190234
Move URL from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=190234
Summary
Move URL from WebCore to WTF
Alex Christensen
Reported
2018-10-02 20:39:27 PDT
Move URL from WebCore to WTF
Attachments
Patch
(1.07 MB, patch)
2018-10-02 20:52 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.21 MB, patch)
2018-10-02 23:02 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-02 23:39 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 00:35 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 01:08 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 01:52 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 02:55 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 04:03 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 05:21 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Add Linux support
(1.22 MB, patch)
2018-10-03 08:36 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.25 MB, patch)
2018-11-30 16:16 PST
,
Keith Miller
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.25 MB, patch)
2018-11-30 17:35 PST
,
Keith Miller
no flags
Details
Formatted Diff
Diff
Show Obsolete
(11)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2018-10-02 20:52:55 PDT
Created
attachment 351473
[details]
Patch
Alex Christensen
Comment 2
2018-10-02 20:53:34 PDT
Could someone give me a hand getting this compiling on Linux?
EWS Watchlist
Comment 3
2018-10-02 20:56:36 PDT
Attachment 351473
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:724: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:727: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:729: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:874: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 106 in 504 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 4
2018-10-02 20:58:05 PDT
Comment on
attachment 351473
[details]
Patch
Attachment 351473
[details]
did not pass bindings-ews (mac): Output:
https://webkit-queues.webkit.org/results/9435803
New failing tests: (JS) JSTestCallTracer.cpp (JS) JSTestCEReactions.cpp (JS) JSTestCEReactionsStringifier.cpp (JS) JSTestClassWithJSBuiltinConstructor.cpp (JS) JSTestCustomConstructorWithNoInterfaceObject.cpp (JS) JSTestActiveDOMObject.cpp (JS) JSTestDOMJIT.cpp (JS) JSTestEnabledBySetting.cpp (JS) JSTestEventConstructor.cpp (JS) JSTestEventTarget.cpp (JS) JSTestException.cpp (JS) JSTestGenerateIsReachable.cpp (JS) JSTestGlobalObject.cpp (JS) JSTestIndexedSetterNoIdentifier.cpp (JS) JSTestIndexedSetterThrowingException.cpp (JS) JSTestIndexedSetterWithIdentifier.cpp (JS) JSTestInterface.cpp (JS) JSTestInterfaceLeadingUnderscore.cpp (JS) JSTestIterable.cpp (JS) JSMapLike.cpp (JS) JSTestMediaQueryListListener.cpp (JS) JSTestNamedAndIndexedSetterNoIdentifier.cpp (JS) JSTestNamedAndIndexedSetterThrowingException.cpp (JS) JSTestNamedAndIndexedSetterWithIdentifier.cpp (JS) JSTestNamedConstructor.cpp (JS) JSTestNamedDeleterNoIdentifier.cpp (JS) JSTestNamedDeleterThrowingException.cpp (JS) JSTestNamedDeleterWithIdentifier.cpp (JS) JSTestNamedDeleterWithIndexedGetter.cpp (JS) JSTestNamedGetterCallWith.cpp (JS) JSTestNamedGetterNoIdentifier.cpp (JS) JSTestNamedGetterWithIdentifier.cpp (JS) JSTestNamedSetterNoIdentifier.cpp (JS) JSTestNamedSetterThrowingException.cpp (JS) JSTestNamedSetterWithIdentifier.cpp (JS) JSTestNamedSetterWithIndexedGetter.cpp (JS) JSTestNamedSetterWithIndexedGetterAndSetter.cpp (JS) JSTestNamedSetterWithOverrideBuiltins.cpp (JS) JSTestNamedSetterWithUnforgableProperties.cpp (JS) JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp (JS) JSTestNode.cpp (JS) JSTestObj.cpp (JS) JSTestOverloadedConstructors.cpp (JS) JSTestOverloadedConstructorsWithSequence.cpp (JS) JSTestOverrideBuiltins.cpp (JS) JSTestPluginInterface.cpp (JS) JSTestPromiseRejectionEvent.cpp (JS) JSReadOnlyMapLike.cpp (JS) JSInterfaceName.cpp (JS) JSTestSerialization.cpp (JS) JSTestSerializationIndirectInheritance.cpp (JS) JSTestSerializationInherit.cpp (JS) JSTestSerializationInheritFinal.cpp (JS) JSTestSerializedScriptValueInterface.cpp (JS) JSTestStringifier.cpp (JS) JSTestStringifierAnonymousOperation.cpp (JS) JSTestStringifierNamedOperation.cpp (JS) JSTestStringifierOperationImplementedAs.cpp (JS) JSTestStringifierOperationNamedToString.cpp (JS) JSTestStringifierReadOnlyAttribute.cpp (JS) JSTestStringifierReadWriteAttribute.cpp (JS) JSTestTypedefs.cpp
Yusuke Suzuki
Comment 5
2018-10-02 21:13:17 PDT
I'm working on Linux part (GTK+) now.
Yusuke Suzuki
Comment 6
2018-10-02 23:02:41 PDT
Created
attachment 351481
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 7
2018-10-02 23:06:48 PDT
Attachment 351481
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:724: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:727: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:729: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:874: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 652 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 8
2018-10-02 23:39:55 PDT
Created
attachment 351483
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 9
2018-10-02 23:43:26 PDT
Attachment 351483
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:724: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:727: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:729: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:874: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 10
2018-10-03 00:35:37 PDT
Created
attachment 351486
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 11
2018-10-03 00:39:08 PDT
Attachment 351486
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:724: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:727: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:729: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:874: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 12
2018-10-03 01:08:18 PDT
Created
attachment 351489
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 13
2018-10-03 01:12:20 PDT
Attachment 351489
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 14
2018-10-03 01:52:18 PDT
Created
attachment 351494
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 15
2018-10-03 01:56:22 PDT
Attachment 351494
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 16
2018-10-03 02:55:21 PDT
Created
attachment 351500
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 17
2018-10-03 03:00:00 PDT
Attachment 351500
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 18
2018-10-03 04:03:15 PDT
Created
attachment 351506
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 19
2018-10-03 04:07:26 PDT
Attachment 351506
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 655 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 20
2018-10-03 05:21:26 PDT
Created
attachment 351512
[details]
Add Linux support + Linux support
EWS Watchlist
Comment 21
2018-10-03 05:26:06 PDT
Attachment 351512
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 656 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 22
2018-10-03 08:36:48 PDT
Created
attachment 351523
[details]
Add Linux support + Linux support
Yusuke Suzuki
Comment 23
2018-10-03 08:37:31 PDT
@Alex: I believe this is now OK in Linux (and possibly in Windows too) :)
EWS Watchlist
Comment 24
2018-10-03 08:41:00 PDT
Attachment 351523
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:385: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:138: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:174: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:191: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 108 in 657 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 25
2018-10-03 10:27:32 PDT
Wow, thanks Yusuke! What a patch!
Alex Christensen
Comment 26
2018-10-04 12:09:27 PDT
Comment on
attachment 351523
[details]
Add Linux support It's unclear whether we actually want to do this. Removing r? for now
Basuke Suzuki
Comment 27
2018-10-16 11:09:20 PDT
(In reply to Alex Christensen from
comment #26
)
> Comment on
attachment 351523
[details]
> Add Linux support > > It's unclear whether we actually want to do this. Removing r? for now
I think it's a important cleanup for moving things up to PAL layer. If we can use URL, there're more candidates for PAL. It seems to huge for one patch. We can start with moving implementation to WTF::URL and keep WebCore::URL to just import WTF::URL for compatibility. Then next patch will replace <WebCore/URL.h> to <WTF/URL.h> and remove the intermediates.
Alex Christensen
Comment 28
2018-10-16 11:12:41 PDT
It's not about the size of the patch. We have it successfully moved in one patch. I don't think this belongs in PAL because it's not an abstraction of a platform in any way. Just moving things to PAL makes PAL less of an interface and more of a move-everything-to-PAL target. The motivation for doing this was to use URLParser from a context that did not use even JavaScriptCore, but that motivation is less urgent now or maybe non-existent.
Basuke Suzuki
Comment 29
2018-10-16 13:55:34 PDT
(In reply to Alex Christensen from
comment #28
)
> It's not about the size of the patch. We have it successfully moved in one > patch. > I don't think this belongs in PAL because it's not an abstraction of a > platform in any way. Just moving things to PAL makes PAL less of an > interface and more of a move-everything-to-PAL target.
No no, I said we may have more chance to move other stuff which uses URL to PAL if URL belongs in WTF. I forgot my demand, maybe content sniffing, for example?
> The motivation for doing this was to use URLParser from a context that did > not use even JavaScriptCore, but that motivation is less urgent now or maybe > non-existent.
Well, URL is fundamental enough to be in WTF, I think. If we can, we should do that.
Keith Miller
Comment 30
2018-11-30 16:16:35 PST
Created
attachment 356258
[details]
Patch for landing
EWS Watchlist
Comment 31
2018-11-30 16:21:57 PST
Attachment 356258
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:387: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/FrameLoader.cpp:128: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" ERROR: Source/WebCore/html/HTMLAttachmentElement.cpp:44: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:139: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:175: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:192: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/UIProcess/SafeBrowsingWarning.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/worklets/WorkletGlobalScope.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/PublicSuffixMac.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:939: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 115 in 679 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 32
2018-11-30 17:35:17 PST
Created
attachment 356272
[details]
Patch for landing
EWS Watchlist
Comment 33
2018-11-30 17:41:07 PST
Attachment 356272
[details]
did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:387: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/FrameLoader.cpp:128: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URLParser.cpp:725: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:726: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:728: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:730: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:731: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/URLParser.cpp:875: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.h" ERROR: Source/WebCore/html/HTMLAttachmentElement.cpp:44: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/ConvertToUTF8String.cpp" ERROR: Source/WebKitLegacy/win/WebView.h:466: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/URL.h:60: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/URL.h:61: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:92: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:94: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:97: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:133: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:134: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:139: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:175: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/URL.h:192: Inline functions should not be in classes annotated with WTF_EXPORT_PRIVATE. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:114: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:382: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:402: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:411: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:423: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:433: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:446: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:456: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:467: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:476: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:488: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:500: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:512: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:524: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:536: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:594: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:833: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1020: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1026: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1028: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/cocoa/NSURLExtras.mm:1189: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/WebKit/UIProcess/SafeBrowsingWarning.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/URLCocoa.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/worklets/WorkletGlobalScope.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/PublicSuffixMac.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:28: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/URL.cpp:99: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:671: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/URL.cpp:883: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:884: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:885: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:886: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:887: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:888: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:889: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:890: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:891: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:892: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:893: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:894: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:895: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:896: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:897: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:898: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:899: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:900: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:901: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:902: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:903: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:904: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:905: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:906: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:907: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:908: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:909: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:910: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:911: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:912: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:913: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:914: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:915: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:916: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:917: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:918: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:919: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:920: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:921: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:922: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:923: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:924: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:925: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:926: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:927: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:928: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:929: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:930: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:931: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:932: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:933: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:934: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:935: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:936: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:937: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:938: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URL.cpp:939: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WTF/wtf/URLHash.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKitLegacy/win/WebResource.h:41: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/cf/URLCF.cpp:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WTF/wtf/cf/CFURLExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 115 in 679 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 34
2018-11-30 20:28:52 PST
https://trac.webkit.org/r238772
Radar WebKit Bug Importer
Comment 35
2018-11-30 20:29:30 PST
<
rdar://problem/46392208
>
Alex Christensen
Comment 36
2018-11-30 23:03:26 PST
This required quite a few little build fixes, but I think they're all done.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug