Bug 192233 - Replace "auto fill" with "AutoFill" in some localizable strings
Summary: Replace "auto fill" with "AutoFill" in some localizable strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 10:37 PST by Wenson Hsieh
Modified: 2018-11-30 13:18 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2018-11-30 10:42 PST, Wenson Hsieh
cfleizach: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.70 MB, application/zip)
2018-11-30 11:47 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.41 MB, application/zip)
2018-11-30 11:52 PST, EWS Watchlist
no flags Details
Patch for landing (6.09 KB, patch)
2018-11-30 11:57 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-sierra (2.02 MB, application/zip)
2018-11-30 12:45 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-30 10:37:57 PST
<rdar://problem/46311614>
Comment 1 Wenson Hsieh 2018-11-30 10:42:01 PST
Created attachment 356197 [details]
Patch
Comment 2 Wenson Hsieh 2018-11-30 11:35:11 PST
Comment on attachment 356197 [details]
Patch

Thanks for the review!

From the looks of it, I might need to rebaseline a test or two.
Comment 3 EWS Watchlist 2018-11-30 11:47:21 PST
Comment on attachment 356197 [details]
Patch

Attachment 356197 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10216998

New failing tests:
accessibility/auto-fill-types.html
Comment 4 EWS Watchlist 2018-11-30 11:47:23 PST
Created attachment 356211 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-11-30 11:52:28 PST
Comment on attachment 356197 [details]
Patch

Attachment 356197 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10216953

New failing tests:
accessibility/auto-fill-types.html
Comment 6 EWS Watchlist 2018-11-30 11:52:30 PST
Created attachment 356215 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Wenson Hsieh 2018-11-30 11:57:15 PST
Created attachment 356217 [details]
Patch for landing
Comment 8 EWS Watchlist 2018-11-30 12:44:59 PST
Comment on attachment 356197 [details]
Patch

Attachment 356197 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10217224

New failing tests:
accessibility/auto-fill-types.html
Comment 9 EWS Watchlist 2018-11-30 12:45:01 PST
Created attachment 356221 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 WebKit Commit Bot 2018-11-30 12:45:43 PST
The commit-queue encountered the following flaky tests while processing attachment 356217 [details]:

inspector/page/empty-or-missing-resources.html bug 192243 (authors: drousso@apple.com and joepeck@webkit.org)
inspector/css/stylesheet-events-inspector-stylesheet.html bug 192244 (authors: drousso@apple.com and joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2018-11-30 12:45:50 PST
The commit-queue encountered the following flaky tests while processing attachment 356217 [details]:

inspector/debugger/setPauseOnAssertions.html bug 192245 (authors: drousso@apple.com and joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2018-11-30 13:18:20 PST
Comment on attachment 356217 [details]
Patch for landing

Clearing flags on attachment: 356217

Committed r238751: <https://trac.webkit.org/changeset/238751>