Bug 192033 - r238510 broke scopes of size zero
Summary: r238510 broke scopes of size zero
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 192015 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-27 13:42 PST by Saam Barati
Modified: 2018-11-28 08:54 PST (History)
13 users (show)

See Also:

Attachments
patch (2.86 KB, patch)
2018-11-27 13:51 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-11-27 13:42:35 PST 
Because maxScopeOffset() for the SymbolTable will be UINT_MAX, this loop runs for UINT_MAX iterations:

for (ScopeOffset offset { 0 }; offset <= symbolTable->maxScopeOffset(); offset += 1) { ... }
Comment 1 Saam Barati 2018-11-27 13:44:58 PST 
<rdar://problem/46281734>
Comment 2 Saam Barati 2018-11-27 13:51:58 PST 
Created attachment 355773 [details]
patch
Comment 3 Keith Miller 2018-11-27 13:56:05 PST 
r=me.
Comment 4 WebKit Commit Bot 2018-11-27 18:03:29 PST 
Comment on attachment 355773 [details]
patch

Clearing flags on attachment: 355773

Committed r238596: <https://trac.webkit.org/changeset/238596>
Comment 5 WebKit Commit Bot 2018-11-27 18:03:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2018-11-28 08:54:41 PST 
*** Bug 192015 has been marked as a duplicate of this bug. ***