Bug 191958 - Object allocation sinking phase needs to iterate each scope offset instead of just iterating the symbol table's hashmap when handling an activation
Summary: Object allocation sinking phase needs to iterate each scope offset instead of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-25 20:36 PST by Saam Barati
Modified: 2018-11-27 13:46 PST (History)
12 users (show)

See Also:

Attachments
patch (4.43 KB, patch)
2018-11-25 20:42 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.43 KB, patch)
2018-11-25 20:44 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-11-25 20:36:36 PST 
Otherwise, we may ignore duplicate entries in the map even though there was more than one scope offset created for them
Comment 1 Saam Barati 2018-11-25 20:37:17 PST 
<rdar://problem/46221877>
Comment 2 Saam Barati 2018-11-25 20:42:52 PST 
Created attachment 355617 [details]
patch
Comment 3 Saam Barati 2018-11-25 20:44:24 PST 
Created attachment 355618 [details]
patch
Comment 4 Yusuke Suzuki 2018-11-25 23:24:49 PST 
Comment on attachment 355618 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-11-26 12:14:50 PST 
Comment on attachment 355618 [details]
patch

Clearing flags on attachment: 355618

Committed r238510: <https://trac.webkit.org/changeset/238510>
Comment 6 WebKit Commit Bot 2018-11-26 12:14:52 PST 
All reviewed patches have been landed.  Closing bug.