Bug 191959 - [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
Summary: [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualif...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 171618
  Show dependency treegraph
 
Reported: 2018-11-25 21:11 PST by Fujii Hironori
Modified: 2018-11-26 18:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2018-11-25 21:18 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.60 MB, application/zip)
2018-11-26 01:47 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-11-25 21:11:27 PST
[Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]

clang-cl reports a following compilation warning:

> [5870/6237] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebView.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebView.cpp:34:
> ..\..\Source\WebKitLegacy\win/MarshallingHelpers.h(65,47):  warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
>     static CFAbsoluteTime MarshallingHelpers::windowsEpochAbsoluteTime();
>                           ~~~~~~~~~~~~~~~~~~~~^

This code has been introduce in following commits.

  https://trac.webkit.org/changeset/23462
  https://trac.webkit.org/changeset/22102
Comment 1 Fujii Hironori 2018-11-25 21:18:53 PST
Created attachment 355619 [details]
Patch
Comment 2 EWS Watchlist 2018-11-26 01:47:39 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-11-26 01:47:40 PST Comment hidden (obsolete)
Comment 4 Fujii Hironori 2018-11-26 18:09:55 PST
Comment on attachment 355619 [details]
Patch

Clearing flags on attachment: 355619

Committed r238542: <https://trac.webkit.org/changeset/238542>
Comment 5 Fujii Hironori 2018-11-26 18:09:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-26 18:10:56 PST
<rdar://problem/46263741>