Bug 191777 – [Win] Reduce the use of WKSI library calls: CoreAnimation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

Move some ancient CoreAnimation code out of WKSI and into Open Source, like we did for iOS and macOS WebKit back in 2017. The WKSI really doesn't provide any benefits to us, and only serves as a road block for outside contributors and a failure point for our build process.

[Radar WebKit Bug Importer]

<rdar://problem/46140542>

[Brent Fulgham]

Created attachment 355153 [details]
Patch

[Brent Fulgham]

Created attachment 355154 [details]
Patch

[Brent Fulgham]

Note: This patch removes the last vestiges of WebkitSystemInterface code in WebKit. We still need to change the build rules to avoid building the project, but nothing links to it or refers to the headers anymore.

[alan baradlay]

Comment on attachment 355154 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 355154 [details]
Patch

Rejecting attachment 355154 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10028273

[EWS Watchlist]

Comment on attachment 355154 [details]
Patch

Attachment 355154 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10029439

New failing tests:
media/no-fullscreen-when-hidden.html

[EWS Watchlist]

Created attachment 355181 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Alex Christensen]

(In reply to Brent Fulgham from comment #4)
> Note: This patch removes the last vestiges of WebkitSystemInterface code in
> WebKit. We still need to change the build rules to avoid building the
> project, but nothing links to it or refers to the headers anymore.
Hooray!

[Brent Fulgham]

(In reply to Build Bot from comment #8)
> Created attachment 355181 [details]
> Archive of layout-test-results from ews126 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

The test blame algorithm is faulty. Removing WKSI from windows-specific code can’t have any effect on iOS simulator builds.

[WebKit Commit Bot]

Comment on attachment 355154 [details]
Patch

Rejecting attachment 355154 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10155232

[WebKit Commit Bot]

Comment on attachment 355154 [details]
Patch

Rejecting attachment 355154 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355154, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKitLegacy/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10155711

[Brent Fulgham]

Committed r238501: <https://trac.webkit.org/changeset/238501>