Bug 191718 - [Win] Reduce the use of WKSI library calls: CFNetwork
Summary: [Win] Reduce the use of WKSI library calls: CFNetwork
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 191777
  Show dependency tree / graph
 
Reported: 2018-11-15 14:40 PST by Brent Fulgham
Modified: 2018-11-16 14:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (27.17 KB, patch)
2018-11-16 11:20 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (7.39 KB, patch)
2018-11-16 11:24 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (26.85 KB, patch)
2018-11-16 11:29 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (26.88 KB, patch)
2018-11-16 13:04 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-11-15 14:40:29 PST 
Move some ancient CFNetwork code out of WKSI and into Open Source, like we did for iOS and macOS WebKit back in 2017. The WKSI really doesn't provide any benefits to us, and only serves as a road block for outside contributors and a failure point for our build process.
Comment 1 Radar WebKit Bug Importer 2018-11-15 14:40:59 PST 
<rdar://problem/46108732>
Comment 2 Brent Fulgham 2018-11-16 11:20:31 PST 
Created attachment 355080 [details]
Patch
Comment 3 Brent Fulgham 2018-11-16 11:24:47 PST 
Created attachment 355083 [details]
Patch
Comment 4 Brent Fulgham 2018-11-16 11:29:09 PST 
Created attachment 355085 [details]
Patch
Comment 5 Brent Fulgham 2018-11-16 13:04:09 PST 
Created attachment 355106 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-11-16 13:43:18 PST 
Comment on attachment 355106 [details]
Patch for landing

Clearing flags on attachment: 355106

Committed r238298: <https://trac.webkit.org/changeset/238298>
Comment 7 WebKit Commit Bot 2018-11-16 13:43:19 PST 
All reviewed patches have been landed.  Closing bug.