Bug 191720 – imported/w3c/web-platform-tests/encoding tests take > 30 minutes to run on debug bots

• Status: REOPENED
• Component: Tools / Tests

[Ryan Haddad]

imported/w3c/web-platform-tests/encoding tests take > 30 minutes to run on debug bots

As seen here: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/5552/steps/layout-test/logs/stdio
14:10:46.627 14808   imported/w3c/web-platform-tests/encoding took 40.5 seconds to run 30 tests.
14:10:46.627 14808   imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis took 682.8 seconds to run 24 tests.
14:10:46.627 14808   imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr took 650.9 seconds to run 17 tests.
14:10:46.627 14808   imported/w3c/web-platform-tests/encoding/legacy-mb-tchinese/big5 took 443.1 seconds to run 16 tests.

They are still a bit slow on release, but not nearly as bad: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/7879/steps/layout-test/logs/stdio
14:09:00.660 55020   imported/w3c/web-platform-tests/encoding took 3.8 seconds to run 30 tests.
14:09:00.660 55020   imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis took 38.7 seconds to run 24 tests.
14:09:00.660 55020   imported/w3c/web-platform-tests/encoding/legacy-mb-korean/euc-kr took 237.9 seconds to run 27 tests.
14:09:00.660 55020   imported/w3c/web-platform-tests/encoding/legacy-mb-tchinese/big5 took 98.0 seconds to run 22 tests.

We should skip these tests on debug.

[Ryan Haddad]

Skipped the tests on debug in https://trac.webkit.org/changeset/238261/webkit

[Radar WebKit Bug Importer]

<rdar://problem/46130109>

[Alexey Proskuryakov]

Did this make tests 30 minutes faster?

[WebKit Commit Bot]

Re-opened since this is blocked by bug 192085

[Ryan Haddad]

(In reply to Alexey Proskuryakov from comment #3)
> Did this make tests 30 minutes faster?
No :(

[Ryan Haddad]

When I checked results before and after my patch on a debug bot, I only saw an improvement of a few minutes. I will probably end up reverting this change.

[Ryan Haddad]

In this example, the test run got 1 minute slower:

Before the skip:
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/8707

With the skip:
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/8708

[Zhifei Fang]

suspect changeset

https://bugs.webkit.org/show_bug.cgi?id=189686

https://bugs.webkit.org/show_bug.cgi?id=189641