Bug 191716 - ASSERTION FAILED: m_outOfLineJumpTargets.contains(bytecodeOffset)
Summary: ASSERTION FAILED: m_outOfLineJumpTargets.contains(bytecodeOffset)
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
Keywords: InRadar
Depends on:
Reported: 2018-11-15 14:28 PST by Tadeu Zagallo
Modified: 2018-11-26 10:15 PST (History)
6 users (show)

See Also:

Patch (5.39 KB, patch)
2018-11-15 14:33 PST, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2018-11-15 14:28:15 PST
After https://bugs.webkit.org/show_bug.cgi?id=187373, when updating jump targets during generatorification, we only stored the new jump target when it changed. However, the out-of-line jump targets are cleared at the beginning of the pass, so we need to store it unconditionally.
Comment 1 Tadeu Zagallo 2018-11-15 14:32:44 PST
Comment 2 Tadeu Zagallo 2018-11-15 14:33:42 PST
Created attachment 354990 [details]
Comment 3 WebKit Commit Bot 2018-11-26 10:15:27 PST
Comment on attachment 354990 [details]

Clearing flags on attachment: 354990

Committed r238499: <https://trac.webkit.org/changeset/238499>
Comment 4 WebKit Commit Bot 2018-11-26 10:15:28 PST
All reviewed patches have been landed.  Closing bug.