WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
187373
New bytecode format for JSC
https://bugs.webkit.org/show_bug.cgi?id=187373
Summary
New bytecode format for JSC
Tadeu Zagallo
Reported
2018-07-05 17:32:21 PDT
Work on a new, more compact and read-only bytecode format to improve memory usage.
Attachments
Patch
(33.03 KB, patch)
2018-07-05 18:23 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews205 for win-future
(12.78 MB, application/zip)
2018-07-07 15:54 PDT
,
EWS Watchlist
no flags
Details
Patch
(43.48 KB, patch)
2018-07-09 16:17 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(70.66 KB, patch)
2018-07-13 03:58 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(140.13 KB, patch)
2018-07-25 19:21 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(187.75 KB, patch)
2018-07-30 19:37 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(273.85 KB, patch)
2018-08-06 18:24 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(281.20 KB, patch)
2018-08-07 20:46 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(285.89 KB, patch)
2018-08-09 14:45 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(308.09 KB, patch)
2018-08-21 08:26 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(339.35 KB, patch)
2018-08-21 22:09 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(344.06 KB, patch)
2018-08-27 09:15 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(409.25 KB, patch)
2018-08-28 08:32 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(578.54 KB, patch)
2018-08-30 17:18 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(622.01 KB, patch)
2018-09-03 15:33 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(656.36 KB, patch)
2018-09-04 14:18 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(674.10 KB, patch)
2018-09-05 15:27 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(742.60 KB, patch)
2018-09-06 12:10 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(756.10 KB, patch)
2018-09-06 15:07 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(761.76 KB, patch)
2018-09-07 15:52 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(796.12 KB, patch)
2018-09-10 06:50 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(897.11 KB, patch)
2018-09-11 08:30 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(940.42 KB, patch)
2018-09-11 15:22 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.07 MB, patch)
2018-09-12 16:25 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.16 MB, patch)
2018-09-13 14:03 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.22 MB, patch)
2018-09-17 19:30 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.22 MB, patch)
2018-09-18 12:49 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.23 MB, patch)
2018-09-24 01:50 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.26 MB, patch)
2018-09-24 17:13 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.27 MB, patch)
2018-09-25 01:12 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.31 MB, patch)
2018-09-25 19:27 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.33 MB, patch)
2018-09-26 13:06 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.34 MB, patch)
2018-09-27 12:47 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.35 MB, patch)
2018-10-05 18:42 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.35 MB, patch)
2018-10-07 11:40 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.36 MB, patch)
2018-10-08 18:10 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.45 MB, patch)
2018-10-10 05:43 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.45 MB, patch)
2018-10-10 08:40 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.45 MB, patch)
2018-10-10 15:40 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.45 MB, patch)
2018-10-11 06:30 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.45 MB, patch)
2018-10-11 09:40 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.46 MB, patch)
2018-10-11 20:02 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.43 MB, patch)
2018-10-12 16:27 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews117 for mac-sierra
(1.84 MB, application/zip)
2018-10-14 00:04 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2
(5.98 MB, application/zip)
2018-10-14 00:08 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.52 MB, patch)
2018-10-14 16:53 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews116 for mac-sierra
(2.16 MB, application/zip)
2018-10-14 18:35 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2
(5.83 MB, application/zip)
2018-10-14 19:10 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.52 MB, patch)
2018-10-15 05:57 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews114 for mac-sierra
(3.04 MB, application/zip)
2018-10-15 08:06 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews124 for ios-simulator-wk2
(5.97 MB, application/zip)
2018-10-15 08:22 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.53 MB, patch)
2018-10-17 06:29 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.53 MB, patch)
2018-10-17 10:27 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.53 MB, patch)
2018-10-17 11:33 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews114 for mac-sierra
(3.22 MB, application/zip)
2018-10-17 14:15 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.53 MB, patch)
2018-10-17 15:22 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.55 MB, patch)
2018-10-17 17:24 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews116 for mac-sierra
(3.24 MB, application/zip)
2018-10-17 19:35 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2
(16.60 MB, application/zip)
2018-10-17 20:23 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.55 MB, patch)
2018-10-18 06:29 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews113 for mac-sierra
(3.03 MB, application/zip)
2018-10-18 08:35 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.55 MB, patch)
2018-10-18 10:36 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews114 for mac-sierra
(3.03 MB, application/zip)
2018-10-18 12:50 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.55 MB, patch)
2018-10-18 17:32 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.56 MB, patch)
2018-10-19 11:24 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.56 MB, patch)
2018-10-19 11:35 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.56 MB, patch)
2018-10-19 11:48 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2
(6.53 MB, application/zip)
2018-10-19 14:23 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.56 MB, patch)
2018-10-19 18:13 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.56 MB, patch)
2018-10-19 23:47 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2
(5.87 MB, application/zip)
2018-10-20 02:10 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.56 MB, patch)
2018-10-20 14:50 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.56 MB, patch)
2018-10-20 23:27 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews203 for win-future
(7.10 MB, application/zip)
2018-10-21 01:35 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2
(6.01 MB, application/zip)
2018-10-21 01:42 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews202 for win-future
(7.16 MB, application/zip)
2018-10-21 03:26 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.56 MB, patch)
2018-10-22 15:04 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews204 for win-future
(7.18 MB, application/zip)
2018-10-22 16:56 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2
(5.94 MB, application/zip)
2018-10-22 17:41 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2
(6.95 MB, application/zip)
2018-10-22 19:39 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.56 MB, patch)
2018-10-23 10:33 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews202 for win-future
(7.18 MB, application/zip)
2018-10-23 12:28 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.56 MB, patch)
2018-10-23 14:04 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews202 for win-future
(12.75 MB, application/zip)
2018-10-23 16:11 PDT
,
EWS Watchlist
no flags
Details
Patch
(1.60 MB, patch)
2018-10-23 17:05 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-23 18:04 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-24 04:58 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-26 02:42 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-26 03:23 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.60 MB, patch)
2018-10-26 12:15 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-26 17:51 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-27 02:12 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Patch
(1.60 MB, patch)
2018-10-27 09:31 PDT
,
Tadeu Zagallo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(92)
View All
Add attachment
proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1
2018-07-05 18:23:04 PDT
Created
attachment 344389
[details]
Patch
EWS Watchlist
Comment 2
2018-07-07 11:56:14 PDT
Attachment 344389
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:3: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:123: opcode_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3
2018-07-07 15:54:06 PDT
Comment on
attachment 344389
[details]
Patch
Attachment 344389
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/8469228
New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 4
2018-07-07 15:54:17 PDT
Created
attachment 344531
[details]
Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Tadeu Zagallo
Comment 5
2018-07-09 16:17:53 PDT
Created
attachment 344635
[details]
Patch
Tadeu Zagallo
Comment 6
2018-07-13 03:58:54 PDT
Created
attachment 344935
[details]
Patch
Tadeu Zagallo
Comment 7
2018-07-25 19:21:00 PDT
Created
attachment 345812
[details]
Patch
Tadeu Zagallo
Comment 8
2018-07-30 19:37:36 PDT
Created
attachment 346138
[details]
Patch
Tadeu Zagallo
Comment 9
2018-08-06 18:24:38 PDT
Created
attachment 346673
[details]
Patch
Tadeu Zagallo
Comment 10
2018-08-07 20:46:08 PDT
Created
attachment 346756
[details]
Patch
Tadeu Zagallo
Comment 11
2018-08-09 14:45:24 PDT
Created
attachment 346862
[details]
Patch
Tadeu Zagallo
Comment 12
2018-08-21 08:26:41 PDT
Created
attachment 347641
[details]
Patch
Tadeu Zagallo
Comment 13
2018-08-21 22:09:02 PDT
Created
attachment 347766
[details]
Patch
Tadeu Zagallo
Comment 14
2018-08-27 09:15:07 PDT
Created
attachment 348149
[details]
Patch
Tadeu Zagallo
Comment 15
2018-08-28 08:32:35 PDT
Created
attachment 348294
[details]
Patch
Tadeu Zagallo
Comment 16
2018-08-30 17:18:03 PDT
Created
attachment 348572
[details]
Patch
Tadeu Zagallo
Comment 17
2018-09-03 15:33:58 PDT
Created
attachment 348792
[details]
Patch
Tadeu Zagallo
Comment 18
2018-09-04 14:18:24 PDT
Created
attachment 348847
[details]
Patch
Tadeu Zagallo
Comment 19
2018-09-05 15:27:22 PDT
Created
attachment 348971
[details]
Patch
Radar WebKit Bug Importer
Comment 20
2018-09-06 10:44:38 PDT
<
rdar://problem/44186758
>
Tadeu Zagallo
Comment 21
2018-09-06 12:10:02 PDT
Created
attachment 349051
[details]
Patch
Tadeu Zagallo
Comment 22
2018-09-06 15:07:55 PDT
Created
attachment 349080
[details]
Patch
Tadeu Zagallo
Comment 23
2018-09-07 15:52:19 PDT
Created
attachment 349211
[details]
Patch
Tadeu Zagallo
Comment 24
2018-09-10 06:50:07 PDT
Created
attachment 349307
[details]
Patch
Tadeu Zagallo
Comment 25
2018-09-11 08:30:04 PDT
Created
attachment 349396
[details]
Patch
Tadeu Zagallo
Comment 26
2018-09-11 15:22:18 PDT
Created
attachment 349473
[details]
Patch
Tadeu Zagallo
Comment 27
2018-09-12 16:25:01 PDT
Created
attachment 349594
[details]
Patch
Tadeu Zagallo
Comment 28
2018-09-13 14:03:30 PDT
Created
attachment 349700
[details]
Patch
Tadeu Zagallo
Comment 29
2018-09-17 19:30:48 PDT
Created
attachment 349991
[details]
Patch
Tadeu Zagallo
Comment 30
2018-09-18 12:49:21 PDT
Created
attachment 350040
[details]
Patch
Tadeu Zagallo
Comment 31
2018-09-24 01:50:05 PDT
Created
attachment 350625
[details]
Patch
Tadeu Zagallo
Comment 32
2018-09-24 17:13:12 PDT
Created
attachment 350716
[details]
Patch
Tadeu Zagallo
Comment 33
2018-09-25 01:12:49 PDT
Created
attachment 350743
[details]
Patch
Caitlin Potter (:caitp)
Comment 34
2018-09-25 15:29:45 PDT
I had a question: Is it strictly necessary to change the llint macro-asm sources to use new style? It doesn't seem strictly required for the bytecode format change, and at least to me, it makes the code a bit trickier to read.
Tadeu Zagallo
Comment 35
2018-09-25 15:52:37 PDT
(In reply to Caitlin Potter (:caitp) from
comment #34
)
> I had a question: > > Is it strictly necessary to change the llint macro-asm sources to use new > style? It doesn't seem strictly required for the bytecode format change, and > at least to me, it makes the code a bit trickier to read.
There's a lot of changes to the llint in this patch, most of which I believe aren't strictly necessary, but some of them make it significantly easier to migrate. I think the 2 biggest changes are using macros for defining opcodes, which saves the trouble of writing each opcode twice (or 4x, if you have 64bit wide and narrow and 32bit wide and narrow) and using the field names to fetch from the instruction stream, which is not necessary, but makes the code easier to understand IMO (I had to spend quite a bit of time to find which types could go into each operand for each opcode).
Tadeu Zagallo
Comment 36
2018-09-25 19:27:34 PDT
Created
attachment 350835
[details]
Patch
Tadeu Zagallo
Comment 37
2018-09-26 13:06:32 PDT
Created
attachment 350888
[details]
Patch
Caitlin Potter (:caitp)
Comment 38
2018-09-26 15:15:13 PDT
Comment on
attachment 350888
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=350888&action=review
I'm not a reviewer, but am experimenting with rebasing our WIP class fields implementation over top of this, just in case it lands first, and in doing this I've found some things that might be good to double check (or consider)
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1133 > break;
I suspect these breaks need to be changed to continues, otherwise the heap might drop structures that this codeblock still thinks it can use, and you'll get a UAF. Also, our Class Fields WIP patch adds an additional property access instruction type which propagates transitions, and with more than one type that matters, I think it probably looks cleaner if we continue using the `switch` --- but I don't have a strong opinion on that.
> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:840 > + move value, t2
maybe we could instead consider having an invariant convention that the dst vreg will always be in t1, or else allow the caller to provide a scratch register to hold the dst vreg.
> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1995 > + return(t3)
shouldn't this be `return(t0)` instead? `t3` was the dst vreg operand, but that logic is now in the return macro right?
Tadeu Zagallo
Comment 39
2018-09-27 12:47:41 PDT
Created
attachment 350987
[details]
Patch
Tadeu Zagallo
Comment 40
2018-10-05 18:42:59 PDT
Created
attachment 351708
[details]
Patch
Tadeu Zagallo
Comment 41
2018-10-07 11:40:05 PDT
Created
attachment 351743
[details]
Patch
Tadeu Zagallo
Comment 42
2018-10-08 18:10:40 PDT
Created
attachment 351841
[details]
Patch
Tadeu Zagallo
Comment 43
2018-10-10 05:43:18 PDT
Created
attachment 351955
[details]
Patch
Tadeu Zagallo
Comment 44
2018-10-10 08:40:49 PDT
Created
attachment 351964
[details]
Patch
EWS Watchlist
Comment 45
2018-10-10 08:43:57 PDT
Attachment 351964
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/InstructionStream.h:113: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:368: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:533: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2469: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2799: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2896: Extra space between return and m_unlinkedCode [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/bytecode/MetadataTable.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/JavaScriptCore/bytecode/MetadataTable.cpp:1: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/JavaScriptCore/jit/JITInlines.h:720: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/dfg/DFGCapabilities.h:48: The parameter name "opcodeID" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGCapabilities.h:48: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4577: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecompiler/ProfileTypeBytecodeFlag.cpp:36: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:140: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:141: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:150: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:159: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:215: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:217: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:289: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:1262: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/jit/JITPropertyAccess.cpp:760: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/jit/JIT.h:321: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/jit/JIT.h:327: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:247: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:248: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:249: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:250: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:251: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:252: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:253: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:254: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:255: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:739: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/jit/JITCall.cpp:59: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/jit/JITCall.cpp:83: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:45: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:46: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:47: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:48: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:49: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:50: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:50: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:51: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:52: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:54: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:55: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:56: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:57: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:59: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:60: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:61: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:62: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:63: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:64: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:64: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:65: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:65: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:66: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:66: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:67: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:69: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:70: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:71: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:72: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:73: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargets.h:41: The parameter name "instruction" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargets.h:42: The parameter name "instruction" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:142: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:156: Missing space before ( in while( [whitespace/parens] [5] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:162: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:167: Missing space before ( in while( [whitespace/parens] [5] ERROR: Source/JavaScriptCore/interpreter/CallFrame.h:186: The parameter name "vpc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/BytecodeDumper.h:41: The parameter name "statusMap" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/BytecodeDumper.h:42: The parameter name "statusMap" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:691: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:692: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:703: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:704: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:713: The parameter name "types" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:105: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1380: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1383: Missing space before ( in if( [whitespace/parens] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1729: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2426: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2686: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2922: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3128: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3768: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4818: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:77: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/interpreter/Interpreter.h:194: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:323: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:47: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:48: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 108 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 46
2018-10-10 15:40:01 PDT
Created
attachment 351995
[details]
Patch
EWS Watchlist
Comment 47
2018-10-10 15:44:40 PDT
Attachment 351995
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:47: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:48: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 13 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 48
2018-10-11 06:30:09 PDT
Created
attachment 352037
[details]
Patch
EWS Watchlist
Comment 49
2018-10-11 06:33:35 PDT
Attachment 352037
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 13 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 50
2018-10-11 09:40:35 PDT
Created
attachment 352050
[details]
Patch
EWS Watchlist
Comment 51
2018-10-11 09:43:39 PDT
Attachment 352050
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/CMakeLists.txt:479: The item "bytecode/MetadataTable.h" should be added only once to the list. [list/duplicate] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 14 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryan Haddad
Comment 52
2018-10-11 13:06:45 PDT
These patches fail to build on the mac-32bit-ews bot: /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/LLInt\ Offsets.build/Script-0F4680AA14BA7FD900BFE272.sh\" /Volumes/Data/EWS/WebKit/WebKitBuild/Release/JSCLLIntSettingsExtractor /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:681 in call to loadisFromInstruction: Could not find macro loadisFromInstruction (MacroError) Command /bin/sh failed with exit code 1
https://webkit-queues.webkit.org/results/9538860
The bot then tries to rebuild without the patch, but hits a different failure (I guess due to generated code from the first attempt): /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:83:5: error: expected expression return extractorTable; ^ /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:94:2: error: expected ';' at end of declaration } ^ ; /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:96:1: error: expected '}' ^ /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:75:1: note: to match this '{' { ^ /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:96:1: error: expected '}' ^ /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:65:15: note: to match this '{' namespace JSC { ^
https://webkit-queues.webkit.org/results/9538864
Tadeu Zagallo
Comment 53
2018-10-11 14:04:27 PDT
(In reply to Ryan Haddad from
comment #52
)
> These patches fail to build on the mac-32bit-ews bot:
Thanks, that's expected, I still haven't implemented 32-bit support for this patch.
Tadeu Zagallo
Comment 54
2018-10-11 20:02:07 PDT
Created
attachment 352126
[details]
Patch
Mark Lam
Comment 55
2018-10-12 14:47:02 PDT
Comment on
attachment 352126
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=352126&action=review
> Source/JavaScriptCore/runtime/GetPutInfo.h:2 > + * Copyright (C) 2018 Apple Inc. All Rights Reserved.
You should say 2015-2018 here.
> Source/JavaScriptCore/runtime/JSType.cpp:18 > + *
nit: Please remove this empty line.
> Source/JavaScriptCore/tools/HeapVerifier.cpp:30 > #include "CodeBlock.h" > +#include "CodeBlockInlines.h"
You can get rid of the #include "CodeBlock.h" here since "CodeBlockInlines.h" should #include it for you.
Tadeu Zagallo
Comment 56
2018-10-12 16:27:12 PDT
Created
attachment 352232
[details]
Patch
EWS Watchlist
Comment 57
2018-10-12 16:31:37 PDT
Attachment 352232
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/CMakeLists.txt:492: The item "bytecode/MetadataTable.h" should be added only once to the list. [list/duplicate] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 13 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 58
2018-10-14 00:04:38 PDT
Comment on
attachment 352232
[details]
Patch
Attachment 352232
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9564939
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 59
2018-10-14 00:04:40 PDT
Created
attachment 352267
[details]
Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 60
2018-10-14 00:08:36 PDT
Comment on
attachment 352232
[details]
Patch
Attachment 352232
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9564470
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 61
2018-10-14 00:08:38 PDT
Created
attachment 352268
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 62
2018-10-14 16:53:08 PDT
Created
attachment 352284
[details]
Patch
EWS Watchlist
Comment 63
2018-10-14 16:56:13 PDT
Attachment 352284
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/CMakeLists.txt:492: The item "bytecode/MetadataTable.h" should be added only once to the list. [list/duplicate] [5] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 13 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 64
2018-10-14 18:35:27 PDT
Comment on
attachment 352284
[details]
Patch
Attachment 352284
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9574409
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 65
2018-10-14 18:35:29 PDT
Created
attachment 352287
[details]
Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 66
2018-10-14 19:10:41 PDT
Comment on
attachment 352284
[details]
Patch
Attachment 352284
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9574515
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 67
2018-10-14 19:10:45 PDT
Created
attachment 352288
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 68
2018-10-15 05:57:45 PDT
Created
attachment 352312
[details]
Patch
EWS Watchlist
Comment 69
2018-10-15 06:02:04 PDT
Attachment 352312
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 70
2018-10-15 08:06:24 PDT
Comment on
attachment 352312
[details]
Patch
Attachment 352312
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9581086
New failing tests: fast/dom/Window/window-postmessage-clone-deep-array.html
EWS Watchlist
Comment 71
2018-10-15 08:06:26 PDT
Created
attachment 352319
[details]
Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 72
2018-10-15 08:22:14 PDT
Comment on
attachment 352312
[details]
Patch
Attachment 352312
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9581130
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 73
2018-10-15 08:22:17 PDT
Created
attachment 352322
[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 74
2018-10-17 06:29:52 PDT
Created
attachment 352565
[details]
Patch
Tadeu Zagallo
Comment 75
2018-10-17 10:27:35 PDT
Created
attachment 352580
[details]
Patch
EWS Watchlist
Comment 76
2018-10-17 10:31:45 PDT
Attachment 352580
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h:120: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 15 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 77
2018-10-17 11:33:02 PDT
Created
attachment 352600
[details]
Patch
EWS Watchlist
Comment 78
2018-10-17 11:44:11 PDT
Attachment 352600
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 14 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 79
2018-10-17 14:15:23 PDT
Comment on
attachment 352600
[details]
Patch
Attachment 352600
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9640540
New failing tests: fast/dom/Window/window-postmessage-clone-deep-array.html
EWS Watchlist
Comment 80
2018-10-17 14:15:26 PDT
Created
attachment 352639
[details]
Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Tadeu Zagallo
Comment 81
2018-10-17 15:22:33 PDT
Created
attachment 352651
[details]
Patch
EWS Watchlist
Comment 82
2018-10-17 15:25:29 PDT
Attachment 352651
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 14 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 83
2018-10-17 17:24:52 PDT
Created
attachment 352664
[details]
Patch
EWS Watchlist
Comment 84
2018-10-17 17:28:26 PDT
Attachment 352664
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 14 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 85
2018-10-17 19:35:07 PDT
Comment on
attachment 352664
[details]
Patch
Attachment 352664
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9645731
New failing tests: fast/dom/Window/window-postmessage-clone-deep-array.html legacy-animation-engine/fast/layers/no-clipping-overflow-hidden-added-after-transition.html
EWS Watchlist
Comment 86
2018-10-17 19:35:09 PDT
Created
attachment 352677
[details]
Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 87
2018-10-17 20:23:23 PDT
Comment on
attachment 352664
[details]
Patch
Attachment 352664
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9646102
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 88
2018-10-17 20:23:26 PDT
Created
attachment 352680
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 89
2018-10-18 06:29:17 PDT
Created
attachment 352689
[details]
Patch
EWS Watchlist
Comment 90
2018-10-18 06:33:00 PDT
Attachment 352689
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 17 in 143 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 91
2018-10-18 07:59:07 PDT
Comment on
attachment 352689
[details]
Patch
Attachment 352689
[details]
did not pass jsc-ews (mac): Output:
https://webkit-queues.webkit.org/results/9650751
New failing tests: profiler-test.yaml/tests/sunspider-1.0/access-nbody.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/string-base64.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/3d-raytrace.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/bitops-nsieve-bits.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/string-validate-input.js.profiler-simple stress/op-push-name-scope-crashes-profiler.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/date-format-tofte.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/math-spectral-norm.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/string-fasta.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/math-partial-sums.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/string-tagcloud.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/crypto-aes.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/3d-morph.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/crypto-sha1.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/access-binary-trees.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/access-fannkuch.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/3d-cube.js.profiler-simple profiler-test.yaml/tests/sunspider-1.0/string-unpack-code.js.profiler-simple apiTests
EWS Watchlist
Comment 92
2018-10-18 08:35:44 PDT
Comment on
attachment 352689
[details]
Patch
Attachment 352689
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9650839
New failing tests: fast/dom/Window/window-postmessage-clone-deep-array.html
EWS Watchlist
Comment 93
2018-10-18 08:35:47 PDT
Created
attachment 352692
[details]
Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Tadeu Zagallo
Comment 94
2018-10-18 10:36:52 PDT
Created
attachment 352707
[details]
Patch
EWS Watchlist
Comment 95
2018-10-18 10:40:21 PDT
Attachment 352707
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 17 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 96
2018-10-18 12:50:05 PDT
Comment on
attachment 352707
[details]
Patch
Attachment 352707
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/9652958
New failing tests: fast/dom/Window/window-postmessage-clone-deep-array.html
EWS Watchlist
Comment 97
2018-10-18 12:50:07 PDT
Created
attachment 352719
[details]
Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Tadeu Zagallo
Comment 98
2018-10-18 17:32:39 PDT
Created
attachment 352750
[details]
Patch
EWS Watchlist
Comment 99
2018-10-18 17:35:54 PDT
Attachment 352750
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 17 in 145 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 100
2018-10-19 11:24:27 PDT
Created
attachment 352806
[details]
Patch
Tadeu Zagallo
Comment 101
2018-10-19 11:35:11 PDT
Created
attachment 352809
[details]
Patch
EWS Watchlist
Comment 102
2018-10-19 11:39:00 PDT
Attachment 352809
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 17 in 146 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 103
2018-10-19 11:48:20 PDT
Created
attachment 352811
[details]
Patch
EWS Watchlist
Comment 104
2018-10-19 11:52:26 PDT
Attachment 352811
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 17 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 105
2018-10-19 14:23:42 PDT
Comment on
attachment 352811
[details]
Patch
Attachment 352811
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9669703
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 106
2018-10-19 14:23:45 PDT
Created
attachment 352823
[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 107
2018-10-19 18:13:00 PDT
Created
attachment 352843
[details]
Patch
Tadeu Zagallo
Comment 108
2018-10-19 23:47:16 PDT
Created
attachment 352852
[details]
Patch
EWS Watchlist
Comment 109
2018-10-19 23:51:46 PDT
Attachment 352852
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:525: WTF_LAZY_FIRST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:539: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 18 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 110
2018-10-20 02:10:46 PDT
Comment on
attachment 352852
[details]
Patch
Attachment 352852
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9675721
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 111
2018-10-20 02:10:49 PDT
Created
attachment 352853
[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 112
2018-10-20 14:50:04 PDT
Created
attachment 352861
[details]
Patch
EWS Watchlist
Comment 113
2018-10-20 14:54:04 PDT
Attachment 352861
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 18 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 114
2018-10-20 23:27:37 PDT
Created
attachment 352863
[details]
Patch
EWS Watchlist
Comment 115
2018-10-20 23:31:56 PDT
Attachment 352863
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 18 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 116
2018-10-21 01:35:20 PDT
Comment on
attachment 352863
[details]
Patch
Attachment 352863
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9683495
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 117
2018-10-21 01:35:28 PDT
Created
attachment 352865
[details]
Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 118
2018-10-21 01:42:56 PDT
Comment on
attachment 352863
[details]
Patch
Attachment 352863
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9683464
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 119
2018-10-21 01:42:59 PDT
Created
attachment 352866
[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 120
2018-10-21 03:26:37 PDT
Comment on
attachment 352863
[details]
Patch
Attachment 352863
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9684160
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 121
2018-10-21 03:26:45 PDT
Created
attachment 352868
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Tadeu Zagallo
Comment 122
2018-10-22 15:04:20 PDT
Created
attachment 352913
[details]
Patch
EWS Watchlist
Comment 123
2018-10-22 15:08:47 PDT
Attachment 352913
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 17 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 124
2018-10-22 16:56:15 PDT
Comment on
attachment 352913
[details]
Patch
Attachment 352913
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9698389
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 125
2018-10-22 16:56:24 PDT
Created
attachment 352926
[details]
Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
EWS Watchlist
Comment 126
2018-10-22 17:41:41 PDT
Comment on
attachment 352913
[details]
Patch
Attachment 352913
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9698662
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 127
2018-10-22 17:41:44 PDT
Created
attachment 352936
[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 128
2018-10-22 19:39:01 PDT
Comment on
attachment 352913
[details]
Patch
Attachment 352913
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/9700479
New failing tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
EWS Watchlist
Comment 129
2018-10-22 19:39:04 PDT
Created
attachment 352948
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Tadeu Zagallo
Comment 130
2018-10-23 10:33:26 PDT
Created
attachment 352981
[details]
Patch
EWS Watchlist
Comment 131
2018-10-23 10:37:28 PDT
Attachment 352981
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 17 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 132
2018-10-23 12:28:16 PDT
Comment on
attachment 352981
[details]
Patch
Attachment 352981
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9707851
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 133
2018-10-23 12:28:24 PDT
Created
attachment 352988
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Tadeu Zagallo
Comment 134
2018-10-23 14:04:44 PDT
Created
attachment 352993
[details]
Patch
EWS Watchlist
Comment 135
2018-10-23 14:08:51 PDT
Attachment 352993
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 17 in 147 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 136
2018-10-23 16:11:10 PDT
Comment on
attachment 352993
[details]
Patch
Attachment 352993
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9709529
New failing tests: js/function-apply-aliased.html
EWS Watchlist
Comment 137
2018-10-23 16:11:24 PDT
Created
attachment 352999
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Tadeu Zagallo
Comment 138
2018-10-23 17:05:11 PDT
Created
attachment 353008
[details]
Patch
EWS Watchlist
Comment 139
2018-10-23 17:12:46 PDT
Attachment 353008
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 140
2018-10-23 18:04:00 PDT
Created
attachment 353009
[details]
Patch
EWS Watchlist
Comment 141
2018-10-23 18:08:03 PDT
Attachment 353009
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 142
2018-10-24 04:58:40 PDT
Created
attachment 353033
[details]
Patch
EWS Watchlist
Comment 143
2018-10-24 07:48:01 PDT
Attachment 353033
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 144
2018-10-25 15:05:23 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
> Source/JavaScriptCore/bytecode/BytecodeList.rb:516 > +op :put_by_val_with_this, > + args: { > + base: VirtualRegister, > + thisValue: VirtualRegister, > + property: VirtualRegister, > + value: VirtualRegister, > + }
I've gotta say, this is really cool. This is a great syntax for defining opcodes and their operands.
> Source/JavaScriptCore/bytecode/BytecodeList.rb:852 > + offset: unsigned, # TODO: this should be ScopeOffset
Please file bugs on bugs.webkit.org for all TODO's and cite the bug URL in the TODO comment.
> Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp:145 > +{ > + auto currentInsertion = m_insertions.begin(); > + auto outOfLineJumpTargets = m_codeBlock->replaceOutOfLineJumpTargets(); > + > + int offset = 0; > + for (InstructionStream::Offset i = 0; i < m_writer.size();) { > + int before = 0; > + int after = 0; > + int remove = 0; > + while (currentInsertion != m_insertions.end() && static_cast<InstructionStream::Offset>(currentInsertion->index.bytecodeOffset) == i) { > + auto size = currentInsertion->length(); > + if (currentInsertion->type == Insertion::Type::Remove) > + remove += size; > + else if (currentInsertion->index.position == Position::Before) > + before += size; > + else if (currentInsertion->index.position == Position::After) > + after += size; > + ++currentInsertion; > + } > + > + offset += before; > + > + if (!remove) { > + auto instruction = m_writer.ref(i); > + updateStoredJumpTargetsForInstruction(m_codeBlock, offset, instruction, [&](int32_t relativeOffset) { > + return adjustJumpTarget(instruction.offset(), instruction.offset() + relativeOffset); > + }, outOfLineJumpTargets); > + i += instruction->size(); > + } else { > + offset -= remove; > + i += remove; > + } > + > + offset += after; > + } > +}
This is the kind of code that smells like it might produce bug tail. Is there a way to write some tests for this? I think that it might be OK if the test gets written after the patch lands. If it was me, I'd try to write a unit test - something that mocks up a code block with various things and runs the rewriter in various ways. I don't know how easy that would be to do. I don't think it's worth it if it's the kind of thing that would take more than a day to write.
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:538 > +#define LINK(...) \ > + CASE(WTF_LAZY_FIRST(__VA_ARGS__)): { \ > + INITIALIZE_METADATA(WTF_LAZY_FIRST(__VA_ARGS__)) \ > + WTF_LAZY_HAS_REST(__VA_ARGS__)({ \ > + WTF_LAZY_FOR_EACH_TERM(LINK_FIELD, WTF_LAZY_REST_(__VA_ARGS__)) \ > + }) \ > + break; \ > + }
There is a lot of WTF in this macro. It's pretty neat.
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:-1261 > - const Vector<unsigned>& propertyAccessInstructions = m_unlinkedCode->propertyAccessInstructions();
Marking my spot. I got this far in my review pass. LGTM so far.
Tadeu Zagallo
Comment 145
2018-10-25 16:06:56 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
>> Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp:145 >> +} > > This is the kind of code that smells like it might produce bug tail. > > Is there a way to write some tests for this? > > I think that it might be OK if the test gets written after the patch lands. If it was me, I'd try to write a unit test - something that mocks up a code block with various things and runs the rewriter in various ways. I don't know how easy that would be to do. I don't think it's worth it if it's the kind of thing that would take more than a day to write.
I agree this is pretty sketchy, and took a couple tries to get right... I think it'd be pretty hard to mock a CodeBlock, but the sketchy part only relies on the Insertions vector, so I think it would easier to move this logic into a separate method and unit test just it. That way, we could only give it the size of the instruction stream, the insertions and a closure and assert that it get's called the right number of times with the respective indices and offsets. I'll file a bug and add a TODO here to add the test once it lands.
Saam Barati
Comment 146
2018-10-25 16:44:30 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
>> Source/JavaScriptCore/bytecode/BytecodeList.rb:852 >> + offset: unsigned, # TODO: this should be ScopeOffset > > Please file bugs on bugs.webkit.org for all TODO's and cite the bug URL in the TODO comment.
And also replace TODO with FIXME
Saam Barati
Comment 147
2018-10-25 16:49:45 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
>> Source/JavaScriptCore/bytecode/BytecodeList.rb:516 >> + } > > I've gotta say, this is really cool. This is a great syntax for defining opcodes and their operands.
I agree. This is really nice
> Source/JavaScriptCore/bytecode/BytecodeList.rb:612 > + condition: VirtualRegister,
naming nit: not sure "condition" is the best name for this given its arbitrary input. I usually think of condition as a boolean
> Source/JavaScriptCore/bytecode/BytecodeList.rb:618 > + condition: VirtualRegister,
ditto
> Source/JavaScriptCore/bytecode/BytecodeList.rb:872 > + scope: VirtualRegister, # offset 1 > + var: unsigned, # offset 2 > + value: VirtualRegister, # offset 3
What do these comments stand for?
Filip Pizlo
Comment 148
2018-10-25 16:58:27 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4835 > + // TODO: we should not have to force this get_by_val to be wide, just guarantee that propertyRegIndex fits
Bug link please.
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:694 > + , RegisterID*>
Not sure this is how most WebKit code would style this. I would have expected to see the comma on the previous line and the "RegisterID*>" indented to line up with the indentation of the previous line (so indented an extra four spaces).
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:706 > + , RegisterID*>
Ditto.
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1199 > + void withWriter(InstructionStreamWriter& writer, Func fn)
I think you want const Func&.
> Source/JavaScriptCore/dfg/DFGCapabilities.cpp:106 > +CapabilityLevel capabilityLevel(OpcodeID opcodeID, CodeBlock* codeBlock, const Instruction* pc)
Marking my spot. LGTM so far.
Tadeu Zagallo
Comment 149
2018-10-25 16:59:09 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
>> Source/JavaScriptCore/bytecode/BytecodeList.rb:612 >> + condition: VirtualRegister, > > naming nit: not sure "condition" is the best name for this given its arbitrary input. I usually think of condition as a boolean
Would you say `value` is better?
>> Source/JavaScriptCore/bytecode/BytecodeList.rb:872 >> + value: VirtualRegister, # offset 3 > > What do these comments stand for?
These were the offsets in the instruction before. It helped me figure out what could be stored at each offset, not sure if it still has any value. The "private" annotation was just to mark that these properties should never be read from the bytecode, but rather from the metadata. I was thinking about implementing something to make the fields private in the struct, but I'm not sure if it's worth it though, but I think there's some value into at least annotating these kinds of properties. (I only did for (get|put)_to_scope, but there are definitely more.)
Keith Miller
Comment 150
2018-10-26 00:07:25 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
still reading but here are some comments for now.
> Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:77 > +/* > static CString idName(int id0, const Identifier& ident) > { > return toCString(ident.impl(), "(@id", id0, ")"); > } > +*/
If this is unused we should probably delete this.
> Source/JavaScriptCore/bytecode/BytecodeList.json:-1 > -[
This makes me so happy!
> Source/JavaScriptCore/bytecode/BytecodeList.rb:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved.
This makes me even happier!
> Source/JavaScriptCore/bytecode/BytecodeUseDef.h:93 > + // functor(instruction[1].u.operand);
Nit: Can we remove these?
> Source/JavaScriptCore/generator/Opcode.rb:168 > + __dumper->dumpOperand(#{arg.name}, #{arg.index == 1});
I think you can make this: m_out.print(comma); dumpValue(#{arg.name}); You'd need to have: Comma comma; before the print_args.
Tadeu Zagallo
Comment 151
2018-10-26 02:42:15 PDT
Created
attachment 353166
[details]
Patch
EWS Watchlist
Comment 152
2018-10-26 02:46:07 PDT
Attachment 353166
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 153
2018-10-26 03:03:26 PDT
Comment on
attachment 353033
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353033&action=review
>> Source/JavaScriptCore/generator/Opcode.rb:168 >> + __dumper->dumpOperand(#{arg.name}, #{arg.index == 1}); > > I think you can make this: > > m_out.print(comma); > dumpValue(#{arg.name}); > > You'd need to have: > > Comma comma; > > before the print_args.
Not sure I follow... I could probably move the if up, i.e. only generate code to print the comma when `arg.index != 1`, but I don't have access to `__dumper->m_out` here.
Tadeu Zagallo
Comment 154
2018-10-26 03:23:20 PDT
Created
attachment 353170
[details]
Patch
EWS Watchlist
Comment 155
2018-10-26 03:26:51 PDT
Attachment 353170
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 156
2018-10-26 11:51:46 PDT
Comment on
attachment 353170
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353170&action=review
r=me I think that my feedback about using common types is the kind of refinement that we can talk about after this lands. I think that the way this works currently is already really nice. Go ahead and land whenenver you're ready!
> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5700 > + auto bytecode = currentInstruction->as<OpJngreater>();
Question about the OpJxxx types - why don't all conditional jumps just share the same type, like OpJCompare or something? Then, it would be a little easier to handle casting of these things.
> Source/JavaScriptCore/jit/JITArithmetic.cpp:57 > + emit_compareAndJump<OpJless>(currentInstruction, LessThan);
... it would mean, for example, that emit_compareAndJump doesn't need to be templatized.
> Source/JavaScriptCore/jit/JITArithmetic.cpp:541 > + emitRightShiftFastPath<OpRshift>(currentInstruction, JITRightShiftGenerator::SignedShift);
Similar thing here - could OpRshift and OpUrshift be the same type?
> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1804 > + prepareForRegularCall > + )
I think that our typical style for llint macro calls would put the ')' right after 'prepareForRegularCall' rather than on its own line.
Tadeu Zagallo
Comment 157
2018-10-26 12:00:41 PDT
Comment on
attachment 353170
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353170&action=review
Nice, I replied to your comment about the types inline. I'll file a bug for it, fix the styling for the LLInt macros and land it right now.
>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5700 >> + auto bytecode = currentInstruction->as<OpJngreater>(); > > Question about the OpJxxx types - why don't all conditional jumps just share the same type, like OpJCompare or something? > > Then, it would be a little easier to handle casting of these things.
Yes, that's what I intended originally with the `op_group`s in BytecodeList.rb, generate one struct for the whole op_group and make each op just extend it with their opcode IDs. I just felt like I was spending too much time on these details and decided to leave it for later. I'll file a bug to implement it though.
>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1804 >> + ) > > I think that our typical style for llint macro calls would put the ')' right after 'prepareForRegularCall' rather than on its own line.
Will fix before landing.
Tadeu Zagallo
Comment 158
2018-10-26 12:15:09 PDT
Created
attachment 353199
[details]
Patch for landing
WebKit Commit Bot
Comment 159
2018-10-26 12:54:49 PDT
Comment on
attachment 353199
[details]
Patch for landing Clearing flags on attachment: 353199 Committed
r237479
: <
https://trac.webkit.org/changeset/237479
>
WebKit Commit Bot
Comment 160
2018-10-26 12:54:53 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 161
2018-10-26 13:35:30 PDT
This change broke the CLoop build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/9630
and Windows:
https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/12336
Tadeu Zagallo
Comment 162
2018-10-26 15:03:11 PDT
Committed
r237484
: <
https://trac.webkit.org/changeset/237484
>
WebKit Commit Bot
Comment 163
2018-10-26 16:26:43 PDT
Re-opened since this is blocked by
bug 190978
Tadeu Zagallo
Comment 164
2018-10-26 17:51:24 PDT
Created
attachment 353213
[details]
Patch
Tadeu Zagallo
Comment 165
2018-10-26 17:52:51 PDT
I've fixed the builds and checked everything is fine on iOS, but I will wait until Monday morning to re-land the patch so I can watch the bots.
EWS Watchlist
Comment 166
2018-10-26 17:55:44 PDT
Attachment 353213
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tadeu Zagallo
Comment 167
2018-10-27 02:12:10 PDT
Created
attachment 353227
[details]
Patch
EWS Watchlist
Comment 168
2018-10-27 02:14:59 PDT
Attachment 353227
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 169
2018-10-27 03:00:08 PDT
Comment on
attachment 353227
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353227&action=review
Cool, small nits.
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815 > + heap()->reportExtraMemoryAllocated(m_instructions->sizeInBytes()); > + > + heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes());
`vm.heap.reportExtraMemoryAllocated` is a bit efficient. And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better.
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:981 > + if (m_instructions->sizeInBytes()) { > + visitor.reportExtraMemoryVisited(m_instructions->sizeInBytes()); > }
This brace is not necessary. And we need to report metadata size too. size_t bytecodeExtraMemory = _instructions->sizeInBytes() + m_metadata->sizeInBytes(); if (bytecodeExtraMemory) visitor.reportExtraMemoryVisited(bytecodeExtraMemory); would be nice.
Tadeu Zagallo
Comment 170
2018-10-27 09:07:00 PDT
Comment on
attachment 353227
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353227&action=review
>> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815 >> + heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes()); > > `vm.heap.reportExtraMemoryAllocated` is a bit efficient. > And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better.
Now that I think about it, this is actually incorrect. We no longer copy the instructions, it's just a pointer to the UnlinkedCodeBlock::m_instructions, so we shouldn't report it at all. Something similar happens with the metadata, where we may or may not copy it, plus a part of its size is owned by the UnlinkedCodeBlock, so I think we'll need a slightly more complicated logic here. I'll push a fix soon.
Tadeu Zagallo
Comment 171
2018-10-27 09:31:14 PDT
Created
attachment 353235
[details]
Patch
EWS Watchlist
Comment 172
2018-10-27 09:35:20 PDT
Attachment 353235
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2478: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ChangeLog:827: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing [changelog/unwantedsecurityterms] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51: g_opcodeMap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52: g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 18 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 173
2018-10-27 11:58:41 PDT
(In reply to Tadeu Zagallo from
comment #170
)
> Comment on
attachment 353227
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=353227&action=review
> > >> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815 > >> + heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes()); > > > > `vm.heap.reportExtraMemoryAllocated` is a bit efficient. > > And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better. > > Now that I think about it, this is actually incorrect. We no longer copy the > instructions, it's just a pointer to the UnlinkedCodeBlock::m_instructions, > so we shouldn't report it at all. Something similar happens with the > metadata, where we may or may not copy it, plus a part of its size is owned > by the UnlinkedCodeBlock, so I think we'll need a slightly more complicated > logic here. I'll push a fix soon.
This doesn’t need to be 100% precise. So you can be approximate in reporting this if it makes things easier, e.g, always report the metadata
Yusuke Suzuki
Comment 174
2018-10-27 13:07:24 PDT
Yeah, the important thing is reportExtraMemoryAllocated and reportExtraMemoryVisited are balanced (if one is called, then another needs to be called) ;)
Tadeu Zagallo
Comment 175
2018-10-28 02:33:52 PDT
I see, that makes sense. I believe the latest version of the patch gets it right and should be more accurate.
Guillaume Emont
Comment 176
2018-10-29 05:52:19 PDT
With the latest version of the patch, though it compiles, it looks like CLOOP is broken on armv7, as shown by the EWS:
https://webkit-queues.webkit.org/results/9764415
The EWS is currently having troubles to figure some things out, but I seem to be able to reproduce a lot of failures.
WebKit Commit Bot
Comment 177
2018-10-29 06:16:22 PDT
Comment on
attachment 353235
[details]
Patch Clearing flags on attachment: 353235 Committed
r237547
: <
https://trac.webkit.org/changeset/237547
>
WebKit Commit Bot
Comment 178
2018-10-29 06:16:26 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 179
2018-10-29 17:54:55 PDT
This makes WebKit build quite noticeably slower. This adds about a minute on a fast machine, or +20% to JavaScriptCore build time.
Tadeu Zagallo
Comment 180
2018-10-29 19:51:32 PDT
Committed
r237576
: <
https://trac.webkit.org/changeset/237576
>
Tadeu Zagallo
Comment 181
2018-10-29 20:09:59 PDT
(In reply to Guillaume Emont from
comment #176
)
> With the latest version of the patch, though it compiles, it looks like > CLOOP is broken on armv7, as shown by the EWS: >
https://webkit-queues.webkit.org/results/9764415
> > The EWS is currently having troubles to figure some things out, but I seem > to be able to reproduce a lot of failures.
I saw that armv7 didn't work as expected and tried to fix it, but even after I got it to build I wasn't able to run any tests on my machine due to issues with the test runner. My suspicion was that the errors could be related to the fact that we rely on unaligned memory accesses for the instruction stream and the metadata table, but I was never able to verify it. I'm happy to help though.
Dominik Inführ
Comment 182
2018-10-30 05:13:48 PDT
Yes, the alignment in the metadata table is definitely a problem. I've uploaded a patch that tries to fix this:
https://bugs.webkit.org/show_bug.cgi?id=187373
.
Dominik Inführ
Comment 183
2018-10-30 05:14:31 PDT
Sorry wrong link, that one should be right now:
https://bugs.webkit.org/show_bug.cgi?id=191062
Alexey Proskuryakov
Comment 184
2018-10-30 13:51:07 PDT
(In reply to Alexey Proskuryakov from
comment #179
)
> This makes WebKit build quite noticeably slower. This adds about a minute on > a fast machine, or +20% to JavaScriptCore build time.
Filed
bug 191079
.
Truitt Savell
Comment 185
2018-11-01 13:57:09 PDT
After the changes in
https://trac.webkit.org/changeset/237547/webkit
32bit-JSC tests had 279 failures. then after
https://trac.webkit.org/changeset/237641/webkit
this was reduced to 64 failures. Build History:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50
Log from 64 failures:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2792/steps/webkit-32bit-jsc-test/logs/stdio
Tadeu Zagallo
Comment 186
2018-11-01 17:58:28 PDT
(In reply to Truitt Savell from
comment #185
)
> After the changes in
https://trac.webkit.org/changeset/237547/webkit
> > 32bit-JSC tests had 279 failures. > > then after
https://trac.webkit.org/changeset/237641/webkit
> > this was reduced to 64 failures. > > Build History: >
https://build.webkit.org/builders/Apple%20High%20Sierra%2032
- > bit%20JSC%20(BuildAndTest)?numbuilds=50 > > Log from 64 failures: >
https://build.webkit.org/builders/Apple%20High%20Sierra%2032
- > bit%20JSC%20%28BuildAndTest%29/builds/2792/steps/webkit-32bit-jsc-test/logs/ > stdio
I've put a patch up in
https://bugs.webkit.org/show_bug.cgi?id=191175
that should fix the actual failures and I'll have another patch soon to skip/mark as slow the tests that are currently timing out.
Tadeu Zagallo
Comment 187
2018-11-02 03:20:46 PDT
I've put the patch to fix all but one of the 32-bit tests in
https://bugs.webkit.org/show_bug.cgi?id=191184
. I'm looking into the last failure now.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug