Bug 187373 – New bytecode format for JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

Work on a new, more compact and read-only bytecode format to improve memory usage.

[Tadeu Zagallo]

Created attachment 344389 [details]
Patch

[EWS Watchlist]

Attachment 344389 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:3:  Streams are highly discouraged.  [readability/streams] [3]
ERROR: Source/JavaScriptCore/wip_bytecode/bytecode_structs.cpp:123:  opcode_length is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 344389 [details]
Patch

Attachment 344389 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8469228

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 344531 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tadeu Zagallo]

Created attachment 344635 [details]
Patch

[Tadeu Zagallo]

Created attachment 344935 [details]
Patch

[Tadeu Zagallo]

Created attachment 345812 [details]
Patch

[Tadeu Zagallo]

Created attachment 346138 [details]
Patch

[Tadeu Zagallo]

Created attachment 346673 [details]
Patch

[Tadeu Zagallo]

Created attachment 346756 [details]
Patch

[Tadeu Zagallo]

Created attachment 346862 [details]
Patch

[Tadeu Zagallo]

Created attachment 347641 [details]
Patch

[Tadeu Zagallo]

Created attachment 347766 [details]
Patch

[Tadeu Zagallo]

Created attachment 348149 [details]
Patch

[Tadeu Zagallo]

Created attachment 348294 [details]
Patch

[Tadeu Zagallo]

Created attachment 348572 [details]
Patch

[Tadeu Zagallo]

Created attachment 348792 [details]
Patch

[Tadeu Zagallo]

Created attachment 348847 [details]
Patch

[Tadeu Zagallo]

Created attachment 348971 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/44186758>

[Tadeu Zagallo]

Created attachment 349051 [details]
Patch

[Tadeu Zagallo]

Created attachment 349080 [details]
Patch

[Tadeu Zagallo]

Created attachment 349211 [details]
Patch

[Tadeu Zagallo]

Created attachment 349307 [details]
Patch

[Tadeu Zagallo]

Created attachment 349396 [details]
Patch

[Tadeu Zagallo]

Created attachment 349473 [details]
Patch

[Tadeu Zagallo]

Created attachment 349594 [details]
Patch

[Tadeu Zagallo]

Created attachment 349700 [details]
Patch

[Tadeu Zagallo]

Created attachment 349991 [details]
Patch

[Tadeu Zagallo]

Created attachment 350040 [details]
Patch

[Tadeu Zagallo]

Created attachment 350625 [details]
Patch

[Tadeu Zagallo]

Created attachment 350716 [details]
Patch

[Tadeu Zagallo]

Created attachment 350743 [details]
Patch

[Caitlin Potter (:caitp)]

I had a question:

Is it strictly necessary to change the llint macro-asm sources to use new style? It doesn't seem strictly required for the bytecode format change, and at least to me, it makes the code a bit trickier to read.

[Tadeu Zagallo]

(In reply to Caitlin Potter (:caitp) from comment #34)
> I had a question:
> 
> Is it strictly necessary to change the llint macro-asm sources to use new
> style? It doesn't seem strictly required for the bytecode format change, and
> at least to me, it makes the code a bit trickier to read.

There's a lot of changes to the llint in this patch, most of which I believe aren't strictly necessary, but some of them make it significantly easier to migrate. I think the 2 biggest changes are using macros for defining opcodes, which saves the trouble of writing each opcode twice (or 4x, if you have 64bit wide and narrow and 32bit wide and narrow) and using the field names to fetch from the instruction stream, which is not necessary, but makes the code easier to understand IMO (I had to spend quite a bit of time to find which types could go into each operand for each opcode).

[Tadeu Zagallo]

Created attachment 350835 [details]
Patch

[Tadeu Zagallo]

Created attachment 350888 [details]
Patch

[Caitlin Potter (:caitp)]

Comment on attachment 350888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350888&action=review

I'm not a reviewer, but am experimenting with rebasing our WIP class fields implementation over top of this, just in case it lands first, and in doing this I've found some things that might be good to double check (or consider)

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1133
>                      break;

I suspect these breaks need to be changed to continues, otherwise the heap might drop structures that this codeblock still thinks it can use, and you'll get a UAF.

Also, our Class Fields WIP patch adds an additional property access instruction type which propagates transitions, and with more than one type that matters, I think it probably looks cleaner if we continue using the `switch` --- but I don't have a strong opinion on that.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:840
> +            move value, t2

maybe we could instead consider having an invariant convention that the dst vreg will always be in t1, or else allow the caller to provide a scratch register to hold the dst vreg.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1995
> +    return(t3)

shouldn't this be `return(t0)` instead? `t3` was the dst vreg operand, but that logic is now in the return macro right?

[Tadeu Zagallo]

Created attachment 350987 [details]
Patch

[Tadeu Zagallo]

Created attachment 351708 [details]
Patch

[Tadeu Zagallo]

Created attachment 351743 [details]
Patch

[Tadeu Zagallo]

Created attachment 351841 [details]
Patch

[Tadeu Zagallo]

Created attachment 351955 [details]
Patch

[Tadeu Zagallo]

Created attachment 351964 [details]
Patch

[EWS Watchlist]

Attachment 351964 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/InstructionStream.h:113:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:368:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:533:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2469:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2799:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2896:  Extra space between return and m_unlinkedCode  [whitespace/declaration] [3]
ERROR: Source/JavaScriptCore/bytecode/MetadataTable.cpp:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Source/JavaScriptCore/bytecode/MetadataTable.cpp:1:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/jit/JITInlines.h:720:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/dfg/DFGCapabilities.h:48:  The parameter name "opcodeID" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/dfg/DFGCapabilities.h:48:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4577:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecompiler/ProfileTypeBytecodeFlag.cpp:36:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:140:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:141:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:150:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:159:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:215:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:217:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/generator/runtime/Fits.h:289:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:1262:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/jit/JITPropertyAccess.cpp:760:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/jit/JIT.h:321:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/jit/JIT.h:327:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:247:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:248:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:249:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:250:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:251:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:252:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:253:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:254:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:255:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:739:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/jit/JITCall.cpp:59:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/jit/JITCall.cpp:83:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:45:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:46:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:47:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:48:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:49:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:50:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:50:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:51:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:52:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:54:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:55:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:56:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:57:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:59:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:60:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:61:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:62:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:63:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:64:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:64:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:65:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:65:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:66:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:66:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:67:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:69:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:70:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:71:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:72:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeKills.h:73:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargets.h:41:  The parameter name "instruction" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargets.h:42:  The parameter name "instruction" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.h:72:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:38:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:142:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:148:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:156:  Missing space before ( in while(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:162:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/PreciseJumpTargetsInlines.h:167:  Missing space before ( in while(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.h:186:  The parameter name "vpc" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/BytecodeDumper.h:41:  The parameter name "statusMap" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/BytecodeDumper.h:42:  The parameter name "statusMap" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:691:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:692:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:703:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:704:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:713:  The parameter name "types" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:105:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1380:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1383:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1729:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2426:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2686:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2922:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3128:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3768:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4818:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:77:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/interpreter/Interpreter.h:194:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:323:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:47:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:48:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 108 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 351995 [details]
Patch

[EWS Watchlist]

Attachment 351995 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:47:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:48:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 13 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352037 [details]
Patch

[EWS Watchlist]

Attachment 352037 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 13 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352050 [details]
Patch

[EWS Watchlist]

Attachment 352050 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:535:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2474:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/llint/LLIntSettingsExtractor.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/CMakeLists.txt:479:  The item "bytecode/MetadataTable.h" should be added only once to the list.  [list/duplicate] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:38:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 14 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryan Haddad]

These patches fail to build on the mac-32bit-ews bot:

    /bin/sh -c \"/Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/LLInt\ Offsets.build/Script-0F4680AA14BA7FD900BFE272.sh\"
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/JSCLLIntSettingsExtractor
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:681 in call to loadisFromInstruction: Could not find macro loadisFromInstruction (MacroError)
Command /bin/sh failed with exit code 1

https://webkit-queues.webkit.org/results/9538860

The bot then tries to rebuild without the patch, but hits a different failure (I guess due to generated code from the first attempt):

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:83:5: error: expected expression
    return extractorTable;
    ^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:94:2: error: expected ';' at end of declaration
}
 ^
 ;
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:96:1: error: expected '}'
^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:75:1: note: to match this '{'
{
^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:96:1: error: expected '}'
^
/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:65:15: note: to match this '{'
namespace JSC {
              ^
https://webkit-queues.webkit.org/results/9538864

[Tadeu Zagallo]

(In reply to Ryan Haddad from comment #52)
> These patches fail to build on the mac-32bit-ews bot:

Thanks, that's expected, I still haven't implemented 32-bit support for this patch.

[Tadeu Zagallo]

Created attachment 352126 [details]
Patch

[Mark Lam]

Comment on attachment 352126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352126&action=review

> Source/JavaScriptCore/runtime/GetPutInfo.h:2
> + * Copyright (C) 2018 Apple Inc. All Rights Reserved.

You should say 2015-2018 here.

> Source/JavaScriptCore/runtime/JSType.cpp:18
> + *

nit: Please remove this empty line.

> Source/JavaScriptCore/tools/HeapVerifier.cpp:30
>  #include "CodeBlock.h"
> +#include "CodeBlockInlines.h"

You can get rid of the #include "CodeBlock.h" here since "CodeBlockInlines.h" should #include it for you.

[Tadeu Zagallo]

Created attachment 352232 [details]
Patch

[EWS Watchlist]

Attachment 352232 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/CMakeLists.txt:492:  The item "bytecode/MetadataTable.h" should be added only once to the list.  [list/duplicate] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:423:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 13 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352232 [details]
Patch

Attachment 352232 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9564939

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352267 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352232 [details]
Patch

Attachment 352232 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9564470

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352268 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352284 [details]
Patch

[EWS Watchlist]

Attachment 352284 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/CMakeLists.txt:492:  The item "bytecode/MetadataTable.h" should be added only once to the list.  [list/duplicate] [5]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 13 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352284 [details]
Patch

Attachment 352284 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9574409

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352287 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352284 [details]
Patch

Attachment 352284 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9574515

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352288 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352312 [details]
Patch

[EWS Watchlist]

Attachment 352312 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:538:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:111:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 12 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352312 [details]
Patch

Attachment 352312 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9581086

New failing tests:
fast/dom/Window/window-postmessage-clone-deep-array.html

[EWS Watchlist]

Created attachment 352319 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352312 [details]
Patch

Attachment 352312 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9581130

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352322 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352565 [details]
Patch

[Tadeu Zagallo]

Created attachment 352580 [details]
Patch

[EWS Watchlist]

Attachment 352580 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h:120:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 15 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352600 [details]
Patch

[EWS Watchlist]

Attachment 352600 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 14 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352600 [details]
Patch

Attachment 352600 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9640540

New failing tests:
fast/dom/Window/window-postmessage-clone-deep-array.html

[EWS Watchlist]

Created attachment 352639 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Tadeu Zagallo]

Created attachment 352651 [details]
Patch

[EWS Watchlist]

Attachment 352651 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:370:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:379:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:534:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2477:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:37:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 14 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352664 [details]
Patch

[EWS Watchlist]

Attachment 352664 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:427:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 14 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352664 [details]
Patch

Attachment 352664 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9645731

New failing tests:
fast/dom/Window/window-postmessage-clone-deep-array.html
legacy-animation-engine/fast/layers/no-clipping-overflow-hidden-added-after-transition.html

[EWS Watchlist]

Created attachment 352677 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352664 [details]
Patch

Attachment 352664 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9646102

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352680 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352689 [details]
Patch

[EWS Watchlist]

Attachment 352689 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 17 in 143 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352689 [details]
Patch

Attachment 352689 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/9650751

New failing tests:
profiler-test.yaml/tests/sunspider-1.0/access-nbody.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/string-base64.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/3d-raytrace.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/bitops-nsieve-bits.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/string-validate-input.js.profiler-simple
stress/op-push-name-scope-crashes-profiler.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/date-format-tofte.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/math-spectral-norm.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/string-fasta.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/math-partial-sums.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/string-tagcloud.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/crypto-aes.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/3d-morph.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/crypto-sha1.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/access-binary-trees.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/access-fannkuch.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/3d-cube.js.profiler-simple
profiler-test.yaml/tests/sunspider-1.0/string-unpack-code.js.profiler-simple
apiTests

[EWS Watchlist]

Comment on attachment 352689 [details]
Patch

Attachment 352689 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9650839

New failing tests:
fast/dom/Window/window-postmessage-clone-deep-array.html

[EWS Watchlist]

Created attachment 352692 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Tadeu Zagallo]

Created attachment 352707 [details]
Patch

[EWS Watchlist]

Attachment 352707 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 17 in 144 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352707 [details]
Patch

Attachment 352707 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9652958

New failing tests:
fast/dom/Window/window-postmessage-clone-deep-array.html

[EWS Watchlist]

Created attachment 352719 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Tadeu Zagallo]

Created attachment 352750 [details]
Patch

[EWS Watchlist]

Attachment 352750 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 17 in 145 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352806 [details]
Patch

[Tadeu Zagallo]

Created attachment 352809 [details]
Patch

[EWS Watchlist]

Attachment 352809 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 17 in 146 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352811 [details]
Patch

[EWS Watchlist]

Attachment 352811 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:537:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2480:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 17 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352811 [details]
Patch

Attachment 352811 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9669703

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352823 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352843 [details]
Patch

[Tadeu Zagallo]

Created attachment 352852 [details]
Patch

[EWS Watchlist]

Attachment 352852 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:525:  WTF_LAZY_FIRST is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:539:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2482:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 18 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352852 [details]
Patch

Attachment 352852 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9675721

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352853 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352861 [details]
Patch

[EWS Watchlist]

Attachment 352861 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 18 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 352863 [details]
Patch

[EWS Watchlist]

Attachment 352863 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:66:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 18 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352863 [details]
Patch

Attachment 352863 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9683495

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352865 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 352863 [details]
Patch

Attachment 352863 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9683464

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352866 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 352863 [details]
Patch

Attachment 352863 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9684160

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352868 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Tadeu Zagallo]

Created attachment 352913 [details]
Patch

[EWS Watchlist]

Attachment 352913 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 17 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352913 [details]
Patch

Attachment 352913 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9698389

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352926 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 352913 [details]
Patch

Attachment 352913 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9698662

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352936 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 352913 [details]
Patch

Attachment 352913 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9700479

New failing tests:
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html

[EWS Watchlist]

Created attachment 352948 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tadeu Zagallo]

Created attachment 352981 [details]
Patch

[EWS Watchlist]

Attachment 352981 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 17 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352981 [details]
Patch

Attachment 352981 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9707851

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 352988 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Tadeu Zagallo]

Created attachment 352993 [details]
Patch

[EWS Watchlist]

Attachment 352993 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 17 in 147 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352993 [details]
Patch

Attachment 352993 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9709529

New failing tests:
js/function-apply-aliased.html

[EWS Watchlist]

Created attachment 352999 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Tadeu Zagallo]

Created attachment 353008 [details]
Patch

[EWS Watchlist]

Attachment 353008 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 353009 [details]
Patch

[EWS Watchlist]

Attachment 353009 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 353033 [details]
Patch

[EWS Watchlist]

Attachment 353033 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4299:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:94:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:361:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 151 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

> Source/JavaScriptCore/bytecode/BytecodeList.rb:516
> +op :put_by_val_with_this,
> +    args: {
> +        base: VirtualRegister,
> +        thisValue: VirtualRegister,
> +        property: VirtualRegister,
> +        value: VirtualRegister,
> +    }

I've gotta say, this is really cool.  This is a great syntax for defining opcodes and their operands.

> Source/JavaScriptCore/bytecode/BytecodeList.rb:852
> +        offset: unsigned, # TODO: this should be ScopeOffset

Please file bugs on bugs.webkit.org for all TODO's and cite the bug URL in the TODO comment.

> Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp:145
> +{
> +    auto currentInsertion = m_insertions.begin();
> +    auto outOfLineJumpTargets = m_codeBlock->replaceOutOfLineJumpTargets();
> +
> +    int offset = 0;
> +    for (InstructionStream::Offset i = 0; i < m_writer.size();) {
> +        int before = 0;
> +        int after = 0;
> +        int remove = 0;
> +        while (currentInsertion != m_insertions.end() && static_cast<InstructionStream::Offset>(currentInsertion->index.bytecodeOffset) == i) {
> +            auto size = currentInsertion->length();
> +            if (currentInsertion->type == Insertion::Type::Remove)
> +                remove += size;
> +            else if (currentInsertion->index.position == Position::Before)
> +                before += size;
> +            else if (currentInsertion->index.position == Position::After)
> +                after += size;
> +            ++currentInsertion;
> +        }
> +
> +        offset += before;
> +
> +        if (!remove) {
> +            auto instruction = m_writer.ref(i);
> +            updateStoredJumpTargetsForInstruction(m_codeBlock, offset, instruction, [&](int32_t relativeOffset) {
> +                return adjustJumpTarget(instruction.offset(), instruction.offset() + relativeOffset);
> +            }, outOfLineJumpTargets);
> +            i += instruction->size();
> +        } else {
> +            offset -= remove;
> +            i += remove;
> +        }
> +
> +        offset += after;
> +    }
> +}

This is the kind of code that smells like it might produce bug tail.

Is there a way to write some tests for this?

I think that it might be OK if the test gets written after the patch lands.  If it was me, I'd try to write a unit test - something that mocks up a code block with various things and runs the rewriter in various ways.  I don't know how easy that would be to do.  I don't think it's worth it if it's the kind of thing that would take more than a day to write.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:538
> +#define LINK(...) \
> +    CASE(WTF_LAZY_FIRST(__VA_ARGS__)): { \
> +        INITIALIZE_METADATA(WTF_LAZY_FIRST(__VA_ARGS__)) \
> +        WTF_LAZY_HAS_REST(__VA_ARGS__)({ \
> +            WTF_LAZY_FOR_EACH_TERM(LINK_FIELD,  WTF_LAZY_REST_(__VA_ARGS__)) \
> +        }) \
> +        break; \
> +    }

There is a lot of WTF in this macro.  It's pretty neat.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:-1261
> -    const Vector<unsigned>& propertyAccessInstructions = m_unlinkedCode->propertyAccessInstructions();

Marking my spot.  I got this far in my review pass.

LGTM so far.

[Tadeu Zagallo]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

>> Source/JavaScriptCore/bytecode/BytecodeRewriter.cpp:145
>> +}
> 
> This is the kind of code that smells like it might produce bug tail.
> 
> Is there a way to write some tests for this?
> 
> I think that it might be OK if the test gets written after the patch lands.  If it was me, I'd try to write a unit test - something that mocks up a code block with various things and runs the rewriter in various ways.  I don't know how easy that would be to do.  I don't think it's worth it if it's the kind of thing that would take more than a day to write.

I agree this is pretty sketchy, and took a couple tries to get right...

I think it'd be pretty hard to mock a CodeBlock, but the sketchy part only relies on the Insertions vector, so I think it would easier to move this logic into a separate method and unit test just it. That way, we could only give it the size of the instruction stream, the insertions and a closure and assert that it get's called the right number of times with the respective indices and offsets.

I'll file a bug and add a TODO here to add the test once it lands.

[Saam Barati]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

>> Source/JavaScriptCore/bytecode/BytecodeList.rb:852
>> +        offset: unsigned, # TODO: this should be ScopeOffset
> 
> Please file bugs on bugs.webkit.org for all TODO's and cite the bug URL in the TODO comment.

And also replace TODO with FIXME

[Saam Barati]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

>> Source/JavaScriptCore/bytecode/BytecodeList.rb:516
>> +    }
> 
> I've gotta say, this is really cool.  This is a great syntax for defining opcodes and their operands.

I agree. This is really nice

> Source/JavaScriptCore/bytecode/BytecodeList.rb:612
> +        condition: VirtualRegister,

naming nit: not sure "condition" is the best name for this given its arbitrary input. I usually think of condition as a boolean

> Source/JavaScriptCore/bytecode/BytecodeList.rb:618
> +        condition: VirtualRegister,

ditto

> Source/JavaScriptCore/bytecode/BytecodeList.rb:872
> +        scope: VirtualRegister, # offset 1
> +        var: unsigned, # offset 2
> +        value: VirtualRegister, # offset 3

What do these comments stand for?

[Filip Pizlo]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:4835
> +        // TODO: we should not have to force this get_by_val to be wide, just guarantee that propertyRegIndex fits

Bug link please.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:694
> +        , RegisterID*>

Not sure this is how most WebKit code would style this.

I would have expected to see the comma on the previous line and the "RegisterID*>" indented to line up with the indentation of the previous line (so indented an extra four spaces).

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:706
> +        , RegisterID*>

Ditto.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1199
> +        void withWriter(InstructionStreamWriter& writer, Func fn)

I think you want const Func&.

> Source/JavaScriptCore/dfg/DFGCapabilities.cpp:106
> +CapabilityLevel capabilityLevel(OpcodeID opcodeID, CodeBlock* codeBlock, const Instruction* pc)

Marking my spot.  LGTM so far.

[Tadeu Zagallo]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

>> Source/JavaScriptCore/bytecode/BytecodeList.rb:612
>> +        condition: VirtualRegister,
> 
> naming nit: not sure "condition" is the best name for this given its arbitrary input. I usually think of condition as a boolean

Would you say `value` is better?

>> Source/JavaScriptCore/bytecode/BytecodeList.rb:872
>> +        value: VirtualRegister, # offset 3
> 
> What do these comments stand for?

These were the offsets in the instruction before. It helped me figure out what could be stored at each offset, not sure if it still has any value.

The "private" annotation was just to mark that these properties should never be read from the bytecode, but rather from the metadata. I was thinking about implementing something to make the fields private in the struct, but I'm not sure if it's worth it though, but I think there's some value into at least annotating these kinds of properties. (I only did for (get|put)_to_scope, but there are definitely more.)

[Keith Miller]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

still reading but here are some comments for now.

> Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:77
> +/*
>  static CString idName(int id0, const Identifier& ident)
>  {
>      return toCString(ident.impl(), "(@id", id0, ")");
>  }
> +*/

If this is unused we should probably delete this.

> Source/JavaScriptCore/bytecode/BytecodeList.json:-1
> -[

This makes me so happy!

> Source/JavaScriptCore/bytecode/BytecodeList.rb:1
> +# Copyright (C) 2018 Apple Inc. All rights reserved.

This makes me even happier!

> Source/JavaScriptCore/bytecode/BytecodeUseDef.h:93
> +    // functor(instruction[1].u.operand);

Nit: Can we remove these?

> Source/JavaScriptCore/generator/Opcode.rb:168
> +                __dumper->dumpOperand(#{arg.name}, #{arg.index == 1});

I think you can make this:

m_out.print(comma); 
dumpValue(#{arg.name});

You'd need to have:

Comma comma;

before the print_args.

[Tadeu Zagallo]

Created attachment 353166 [details]
Patch

[EWS Watchlist]

Attachment 353166 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 151 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Comment on attachment 353033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353033&action=review

>> Source/JavaScriptCore/generator/Opcode.rb:168
>> +                __dumper->dumpOperand(#{arg.name}, #{arg.index == 1});
> 
> I think you can make this:
> 
> m_out.print(comma); 
> dumpValue(#{arg.name});
> 
> You'd need to have:
> 
> Comma comma;
> 
> before the print_args.

Not sure I follow... I could probably move the if up, i.e. only generate code to print the comma when `arg.index != 1`, but I don't have access to `__dumper->m_out` here.

[Tadeu Zagallo]

Created attachment 353170 [details]
Patch

[EWS Watchlist]

Attachment 353170 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 151 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 353170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353170&action=review

r=me

I think that my feedback about using common types is the kind of refinement that we can talk about after this lands.  I think that the way this works currently is already really nice.

Go ahead and land whenenver you're ready!

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5700
> +            auto bytecode = currentInstruction->as<OpJngreater>();

Question about the OpJxxx types - why don't all conditional jumps just share the same type, like OpJCompare or something?

Then, it would be a little easier to handle casting of these things.

> Source/JavaScriptCore/jit/JITArithmetic.cpp:57
> +    emit_compareAndJump<OpJless>(currentInstruction, LessThan);

... it would mean, for example, that emit_compareAndJump doesn't need to be templatized.

> Source/JavaScriptCore/jit/JITArithmetic.cpp:541
> +        emitRightShiftFastPath<OpRshift>(currentInstruction, JITRightShiftGenerator::SignedShift);

Similar thing here - could OpRshift and OpUrshift be the same type?

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1804
> +        prepareForRegularCall
> +    )

I think that our typical style for llint macro calls would put the ')' right after 'prepareForRegularCall' rather than on its own line.

[Tadeu Zagallo]

Comment on attachment 353170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353170&action=review

Nice, I replied to your comment about the types inline. I'll file a bug for it, fix the styling for the LLInt macros and land it right now.

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:5700
>> +            auto bytecode = currentInstruction->as<OpJngreater>();
> 
> Question about the OpJxxx types - why don't all conditional jumps just share the same type, like OpJCompare or something?
> 
> Then, it would be a little easier to handle casting of these things.

Yes, that's what I intended originally with the `op_group`s in BytecodeList.rb, generate one struct for the whole op_group and make each op just extend it with their opcode IDs. I just felt like I was spending too much time on these details and decided to leave it for later. I'll file a bug to implement it though.

>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1804
>> +    )
> 
> I think that our typical style for llint macro calls would put the ')' right after 'prepareForRegularCall' rather than on its own line.

Will fix before landing.

[Tadeu Zagallo]

Created attachment 353199 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 353199 [details]
Patch for landing

Clearing flags on attachment: 353199

Committed r237479: <https://trac.webkit.org/changeset/237479>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change broke the CLoop build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/9630

and Windows:
https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/12336

[Tadeu Zagallo]

Committed r237484: <https://trac.webkit.org/changeset/237484>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 190978

[Tadeu Zagallo]

Created attachment 353213 [details]
Patch

[Tadeu Zagallo]

I've fixed the builds and checked everything is fine on iOS, but I will wait until Monday morning to re-land the patch so I can watch the bots.

[EWS Watchlist]

Attachment 353213 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tadeu Zagallo]

Created attachment 353227 [details]
Patch

[EWS Watchlist]

Attachment 353227 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2481:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 353227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353227&action=review

Cool, small nits.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815
> +    heap()->reportExtraMemoryAllocated(m_instructions->sizeInBytes());
> +
> +    heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes());

`vm.heap.reportExtraMemoryAllocated` is a bit efficient.
And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:981
> +    if (m_instructions->sizeInBytes()) {
> +        visitor.reportExtraMemoryVisited(m_instructions->sizeInBytes());
>      }

This brace is not necessary. And we need to report metadata size too.
size_t bytecodeExtraMemory = _instructions->sizeInBytes() + m_metadata->sizeInBytes();
if (bytecodeExtraMemory)
    visitor.reportExtraMemoryVisited(bytecodeExtraMemory);

would be nice.

[Tadeu Zagallo]

Comment on attachment 353227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353227&action=review

>> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815
>> +    heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes());
> 
> `vm.heap.reportExtraMemoryAllocated` is a bit efficient.
> And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better.

Now that I think about it, this is actually incorrect. We no longer copy the instructions, it's just a pointer to the UnlinkedCodeBlock::m_instructions, so we shouldn't report it at all. Something similar happens with the metadata, where we may or may not copy it, plus a part of its size is owned by the UnlinkedCodeBlock, so I think we'll need a slightly more complicated logic here. I'll push a fix soon.

[Tadeu Zagallo]

Created attachment 353235 [details]
Patch

[EWS Watchlist]

Attachment 353235 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:371:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:380:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:532:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:544:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:2478:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1298:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4297:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:95:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/BytecodeUseDef.h:351:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ChangeLog:827:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzing, fuzzing  [changelog/unwantedsecurityterms] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:112:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSType.cpp:43:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:294:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:298:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:304:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:51:  g_opcodeMap is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:52:  g_opcodeMapWide is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 18 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

(In reply to Tadeu Zagallo from comment #170)
> Comment on attachment 353227 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353227&action=review
> 
> >> Source/JavaScriptCore/bytecode/CodeBlock.cpp:815
> >> +    heap()->reportExtraMemoryAllocated(m_metadata->sizeInBytes());
> > 
> > `vm.heap.reportExtraMemoryAllocated` is a bit efficient.
> > And `vm.heap.reportExtraMemoryAllocate(m_instructions->sizeInBytes() + m_metadata->sizeInBytes())` is better.
> 
> Now that I think about it, this is actually incorrect. We no longer copy the
> instructions, it's just a pointer to the UnlinkedCodeBlock::m_instructions,
> so we shouldn't report it at all. Something similar happens with the
> metadata, where we may or may not copy it, plus a part of its size is owned
> by the UnlinkedCodeBlock, so I think we'll need a slightly more complicated
> logic here. I'll push a fix soon.

This doesn’t need to be 100% precise. So you can be approximate in reporting this if it makes things easier, e.g, always report the metadata

[Yusuke Suzuki]

Yeah, the important thing is reportExtraMemoryAllocated and reportExtraMemoryVisited are balanced (if one is called, then another needs to be called) ;)

[Tadeu Zagallo]

I see, that makes sense. I believe the latest version of the patch gets it right and should be more accurate.

[Guillaume Emont]

With the latest version of the patch, though it compiles, it looks like CLOOP is broken on armv7, as shown by the EWS: https://webkit-queues.webkit.org/results/9764415

The EWS is currently having troubles to figure some things out, but I seem to be able to reproduce a lot of failures.

[WebKit Commit Bot]

Comment on attachment 353235 [details]
Patch

Clearing flags on attachment: 353235

Committed r237547: <https://trac.webkit.org/changeset/237547>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This makes WebKit build quite noticeably slower. This adds about a minute on a fast machine, or +20% to JavaScriptCore build time.

[Tadeu Zagallo]

Committed r237576: <https://trac.webkit.org/changeset/237576>

[Tadeu Zagallo]

(In reply to Guillaume Emont from comment #176)
> With the latest version of the patch, though it compiles, it looks like
> CLOOP is broken on armv7, as shown by the EWS:
> https://webkit-queues.webkit.org/results/9764415
> 
> The EWS is currently having troubles to figure some things out, but I seem
> to be able to reproduce a lot of failures.

I saw that armv7 didn't work as expected and tried to fix it, but even after I got it to build I wasn't able to run any tests on my machine due to issues with the test runner. My suspicion was that the errors could be related to the fact that we rely on unaligned memory accesses for the instruction stream and the metadata table, but I was never able to verify it. I'm happy to help though.

[Dominik Inführ]

Yes, the alignment in the metadata table is definitely a problem. I've uploaded a patch that tries to fix this: https://bugs.webkit.org/show_bug.cgi?id=187373.

[Dominik Inführ]

Sorry wrong link, that one should be right now: https://bugs.webkit.org/show_bug.cgi?id=191062

[Alexey Proskuryakov]

(In reply to Alexey Proskuryakov from comment #179)
> This makes WebKit build quite noticeably slower. This adds about a minute on
> a fast machine, or +20% to JavaScriptCore build time.

Filed bug 191079.

[Truitt Savell]

After the changes in https://trac.webkit.org/changeset/237547/webkit

32bit-JSC tests had 279 failures. 

then after https://trac.webkit.org/changeset/237641/webkit

this was reduced to 64 failures. 

Build History: 
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50

Log from 64 failures:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2792/steps/webkit-32bit-jsc-test/logs/stdio

[Tadeu Zagallo]

 (In reply to Truitt Savell from comment #185)
> After the changes in https://trac.webkit.org/changeset/237547/webkit
> 
> 32bit-JSC tests had 279 failures. 
> 
> then after https://trac.webkit.org/changeset/237641/webkit
> 
> this was reduced to 64 failures. 
> 
> Build History: 
> https://build.webkit.org/builders/Apple%20High%20Sierra%2032-
> bit%20JSC%20(BuildAndTest)?numbuilds=50
> 
> Log from 64 failures:
> https://build.webkit.org/builders/Apple%20High%20Sierra%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/2792/steps/webkit-32bit-jsc-test/logs/
> stdio

I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191175 that should fix the actual failures and I'll have another patch soon to skip/mark as slow the tests that are currently timing out.

[Tadeu Zagallo]

I've put the patch to fix all but one of the 32-bit tests in https://bugs.webkit.org/show_bug.cgi?id=191184. I'm looking into the last failure now.