Created attachment 354792 [details]
Screenshot 2.23.0 (layout problem)
In builds from svn, the hyperlink underscore is very close to the text, such that it is obscured by the text.
Attached are screenshots under 2.23.0 (layout issue) and under 2.22.3 (layout OK). Both are under epiphany 3.30.2.
The 'Use system fonts' preference has no effect, nor does zooming in or out.
Created attachment 354793 [details]
Screenshot 2.22.3 (layout OK)
Myles you broke hyperlinks aaaah!
Uh oh, there must have been some subtle difference between the Mac version and the GTK version. From looking at the screenshots it looks like the coordinate system for calculating the intersection positions is wrong. It's difficult for me to debug GTK since I don't have a machine... I'd be happy to work with someone who has a GTK machine to try to figure this out.
From bug #191239:
>> + , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))
> This is what broke cairo ports, we didn't have that scale(1, -1) in the cairo impl.
Created attachment 355329 [details]
Comment on attachment 355329 [details]
Well it's not a good solution, but this is a release blocker and it would be nice to release.
Maybe Myles would know the right approach.
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 355329 [details]
> Well it's not a good solution, but this is a release blocker and it would be
> nice to release.
> Maybe Myles would know the right approach.
I think this solution is fine.
Sorry for missing that scale :(
(In reply to Myles C. Maxfield from comment #7)
> I think this solution is fine.
Why does only one port need the vertical flip? And in cross-platform code?
Committed r238413: <https://trac.webkit.org/changeset/238413>
Thank you! Fix verified in build from SVN source 2018-11-21 @ 1200WET